[vtk-developers] [VTK 0012385]: Please don't exclude Intel GPU's from VolumeRendering/vtkOpenGLGPUVolumeRayCastMapper.cxx

[David Partyka]

Hi Dominique,

After some internal discussion we have decided to revert this change. The
reason that check was implemented was because often older versions of Mesa
report that they support various OpenGL extensions falsely which then result
in crashes. If further refinement of this check can be developed that would
be preferred. Specifically if we can pinpoint a minimum version of Mesa
that vtkOpenGLGPUVolumeRayCastMapper for sure works with. Until then, in our
effort to minimize crashes the check will have to remain in place.

On Wed, Jul 27, 2011 at 11:22 AM, Dominique Belhachemi
<domibel at debian.org>wrote:

> Intel support has been dropped again. What happened?
>
> Dominique
>
>
> On Mon, Jul 25, 2011 at 1:36 PM, David Partyka
> <david.partyka at kitware.com> wrote:
> > Just merged this into both 5.8 and master.
> >
> > On Mon, Jul 25, 2011 at 10:28 AM, David Partyka <
> david.partyka at kitware.com>
> > wrote:
> >>
> >> I'll take a look at it for 5.8
> >>
> >> On Mon, Jul 25, 2011 at 10:17 AM, Dominique Belhachemi
> >> <domibel at debian.org> wrote:
> >>>
> >>> Hi,
> >>>
> >>> A gerrit patch is ready for a review.
> >>> http://review.source.kitware.com/#change,2184
> >>>
> >>> I hope it can make it in the 5.8 release so that Intel GPU user can
> >>> report their experience with VTK.
> >>>
> >>> Thanks
> >>> Dominique
> >>>
> >>>
> >>> On Wed, Jul 20, 2011 at 7:58 PM, Mantis Bug Tracker
> >>> <mantis at public.kitware.com> wrote:
> >>> >
> >>> > The following issue has been SUBMITTED.
> >>> >
> ======================================================================
> >>> > http://vtk.org/Bug/view.php?id=12385
> >>> >
> ======================================================================
> >>> > Reported By:                domibel
> >>> > Assigned To:
> >>> >
> ======================================================================
> >>> > Project:                    VTK
> >>> > Issue ID:                   12385
> >>> > Category:                   (No Category)
> >>> > Reproducibility:            have not tried
> >>> > Severity:                   minor
> >>> > Priority:                   urgent
> >>> > Status:                     backlog
> >>> > Project:                    TBD
> >>> > Type:                       usability
> >>> >
> ======================================================================
> >>> > Date Submitted:             2011-07-20 18:58 CDT
> >>> > Last Modified:              2011-07-20 18:58 CDT
> >>> >
> ======================================================================
> >>> > Summary:                    Please don't exclude Intel GPU's from
> >>> > VolumeRendering/vtkOpenGLGPUVolumeRayCastMapper.cxx
> >>> > Description:
> >>> > Hi,
> >>> >
> >>> > Intel GPU's contain as usual the substring "Mesa" in the OpenGL
> >>> > renderer string.
> >>> >
> >>> > e.g.: Mesa DRI Mobile Intel® GM45 Express Chipset GEM 20091221 2009Q4
> >>> > x86/MMX/SSE2
> >>> >
> >>> > The following code excludes all those GPU's. I think this check
> should
> >>> > be
> >>> > removed. It is better to inform the user what OpenGL feature is
> >>> > missing.
> >>> >
> >>> >
> >>> > in VolumeRendering/vtkOpenGLGPUVolumeRayCastMapper.cxx:2160
> >>> >
> >>> >  const char *gl_version=reinterpret_cast<const char
> >>> > *>(glGetString(GL_VERSION));
> >>> >  if(strstr(gl_version,"Mesa")!=0)
> >>> >    {
> >>> >    // - GL_VENDOR cannot be used because it can be "Brian Paul" or
> >>> >    // "Mesa project"
> >>> >    // - GL_RENDERER cannot be used because it can be "Software
> >>> > Rasterizer" or
> >>> >    // "Mesa X11"
> >>> >    // - GL_VERSION is more robust. It has things like "2.0 Mesa
> 7.0.4"
> >>> > or
> >>> >    // "2.1 Mesa 7.2" or "2.1 Mesa 7.3-devel"
> >>> >    // Mesa does not work with multiple draw buffers:
> >>> >    // "framebuffer has bad draw buffer"
> >>> >    // "render clipped 1 ERROR (x506) invalid framebuffer operation
> ext"
> >>> >    this->LoadExtensionsSucceeded=0;
> >>> >    return;
> >>> >    }
> >>> >
> >>> >
> >>> > Thanks
> >>> > Dominique
> >>> >
> ======================================================================
> >>> >
> >>> > Issue History
> >>> > Date Modified    Username       Field                    Change
> >>> >
> ======================================================================
> >>> > 2011-07-20 18:58 domibel        New Issue
> >>> >
> ======================================================================
> >>> >
> >>> > _______________________________________________
> >>> > Powered by www.kitware.com
> >>> >
> >>> > Visit other Kitware open-source projects at
> >>> > http://www.kitware.com/opensource/opensource.html
> >>> >
> >>> > Follow this link to subscribe/unsubscribe:
> >>> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >>> >
> >>> >
> >>> _______________________________________________
> >>> Powered by www.kitware.com
> >>>
> >>> Visit other Kitware open-source projects at
> >>> http://www.kitware.com/opensource/opensource.html
> >>>
> >>> Follow this link to subscribe/unsubscribe:
> >>> http://www.vtk.org/mailman/listinfo/vtk-developers
> >>>
> >>
> >
> >
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20110727/f10ceb76/attachment.html>