[vtk-developers] Anyone know vtkPolyhedron::GenerateFaces?

[Sean McBride]

Hi again,

So I've been trying to get VTK building cleanly with clang.... I've
fixed many warnings, but some I'm too scared to attempt:

VTK/Filtering/vtkPolyhedron.cxx:1647:12: warning: explicitly assigning a
      variable of type 'vtkIdType' (aka 'long long') to itself [-Wself-assign]
        id = id;
        ~~ ^ ~~

In vtkPolyhedron::GenerateFaces(), what is the point of:

      if (id < 0)
        {
        id = id;
        }

maybe it should be:

      if (id < 0)
        {
        id = fid;
        }

I dunno.... very fishy....

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada