[vtk-developers] New "NeedBaselines" conditional for tests

Marcus D. Hanwell marcus.hanwell at kitware.com
Sat Dec 31 21:20:41 EST 2011


On Sat, Dec 31, 2011 at 6:32 PM, David Doria <daviddoria at gmail.com> wrote:
> After running a dashboard on a machine without VTK_DATA, I think there is an
> issue with several of the tests:
> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=1866063
>
> As an example consider:
> http://www.cdash.org/CDash/testDetails.php?test=129458658&build=1866063
>
> In the CMakeLists.txt of Widgets/Testing/Cxx, BoxWidget2.cxx is NOT placed
> in the "needs VTK_DATA" conditional. It is correct that for this test no
> input data is necessary. However, the Baseline images are not available to
> check the output of the test because VTK_DATA is not available. Does there
> need to be another conditional, something like "Need_Baselines" added to
> some of the CMakeLists.txt files? The tests failing on this dashboard would
> then be moved into that conditional. It would essentially be the same check
> for VTK_DATA, but it seems better to keep them separated by which ones need
> input data and which only need baseline data.
>
> I think the dashboard should be green no matter if VTK_DATA is available or
> not, there would just be fewer tests run.
>
> Thoughts?

I think they should just use the existing VTK_DATA variable, rather
than inventing a new one. I made a similar update to the charts a
while back because of this issue.

Marcus



More information about the vtk-developers mailing list