[vtk-developers] Warning in vtkExtractSelectedIds

[David Gobbi]

Hi Utkarsh,

I think that I might have found a bug in that class.  At line 880,
the "j" is used as a for-loop index even though it was already
used in the enclosing for-loop:

http://vtk.org/gitweb?p=VTK.git;a=blob;f=Graphics/vtkExtractSelectedIds.cxx;h=0d45ffc7#l870

Can you take a look?

 - David


On Fri, Dec 30, 2011 at 10:23 AM, Utkarsh Ayachit
<utkarsh.ayachit at kitware.com> wrote:
> That sounds great to me. Thanks.
>
> Utkarsh
>
> On Fri, Dec 30, 2011 at 11:13 AM, David Gobbi <david.gobbi at gmail.com> wrote:
>> On Fri, Dec 30, 2011 at 9:02 AM, David Doria <daviddoria at gmail.com> wrote:
>>> On Fri, Dec 30, 2011 at 10:26 AM, David Gobbi <david.gobbi at gmail.com> wrote:
>>>> The only way to avoid shadow warnings is to use a new name
>>>
>>> The name VTK_TT is used inside the macro, so I don't think there is an
>>> easy way to change it in the second call. Anyone have a "quick fix" we
>>> can apply now to fix the warning, and then we can put the proposed
>>> rewrite on the todo list?
>>
>> My proposed rewrite is fairly straightforward.  Since it was on my mind,
>> I've already gotten started on it, and will submit it to gerrit soon.
>>
>>  - David
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>