[vtk-developers] Change in VTK[master]: ENH: Added vector-on-plane projection and related test

David Doria daviddoria at gmail.com
Tue Apr 5 12:24:06 EDT 2011


Can't we add a hook that doesn't affect already checked in files? Or make a
giant "fix style" commit?

David


On Tue, Apr 5, 2011 at 12:23 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> I recall that VTK does not have that hook. It is because so much of vtk
> already has trailing spaces. VTYK has never (at least for many years) used a
> style checker and their are many violations.
>
> Bill
>
>
>
> On Tue, Apr 5, 2011 at 12:19 PM, David Doria <daviddoria at gmail.com> wrote:
>
>> I created a brand new fresh git clone this morning and ran it.
>>
>> David
>>
>>
>>
>> On Tue, Apr 5, 2011 at 12:18 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:
>>
>>> The SetupForDevelopment.sh script  should have taken care of it. When was
>>> the last time you ran it?
>>>
>>> On Tue, Apr 5, 2011 at 12:07 PM, Code Review <review at kitware.com> wrote:
>>>
>>>> From David Doria <daviddoria at gmail.com>:
>>>>
>>>> David Doria has posted comments on this change.
>>>>
>>>>
>>>> Change subject: ENH: Added vector-on-plane projection and related test
>>>> ......................................................................
>>>>
>>>>
>>>> Patch Set 1:
>>>>
>>>> I ran the SetupForDevelopment.sh script - I thought this was supposed to
>>>> take care of everything.
>>>>
>>>>
>>>> --
>>>> To view, visit http://review.source.kitware.com/1317
>>>> To unsubscribe, visit http://review.source.kitware.com/settings
>>>>
>>>> Gerrit-MessageType: comment
>>>> Gerrit-Change-Id: I7220a5b0c2c24dffe99b354b7605c8a9f2d91865
>>>> Gerrit-PatchSet: 1
>>>> Gerrit-Project: VTK
>>>> Gerrit-Branch: master
>>>> Gerrit-Owner: David Doria <daviddoria at gmail.com>
>>>> Gerrit-Reviewer: Arnaud Gelas <arnaud_gelas at hms.harvard.edu>
>>>> Gerrit-Reviewer: Bill Lorensen <bill.lorensen at gmail.com>
>>>> Gerrit-Reviewer: David Doria <daviddoria at gmail.com>
>>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20110405/210ab20e/attachment.html>


More information about the vtk-developers mailing list