[vtk-developers] Removed "lib" prefix from python modules

Marcus D. Hanwell marcus.hanwell at kitware.com
Fri Sep 24 15:08:19 EDT 2010


On Fri, Sep 24, 2010 at 10:57 AM, David Gobbi <david.gobbi at gmail.com> wrote:

> On Fri, Sep 24, 2010 at 8:45 AM, Marcus D. Hanwell
> <marcus.hanwell at kitware.com> wrote:
> > On Fri, Sep 24, 2010 at 10:29 AM, David Gobbi <david.gobbi at gmail.com>
> wrote:
> >>
> >> But here is a caveat: setting PYTHON_MODULE_PREFIX might not be
> >> enough because there is a bug in CMake's Modules/FindPythonLibs.cmake.
> >> It does not actually set the prefix of the module, it only sets the
> >> prefix in the name of the "init" function.  I've fixed this bug in
> >> VTK's copy of FindPythonLibs.cmake, and someone should copy
> >> my changes from this file into CMake.
> >
> > I can take a look at that.
>
> Another thing that FindPythonLibs.cmake does not do is set the suffix
> to ".pyd" on Windows.  It didn't cross my mind when I was fixing the
> file, but since the ".dll" module suffix is officially deprecated by
> python, it might be good to have that in FindPythonLibs.cmake instead
> of scattered around various CMake files in various projects.
>
> I just pushed the updated FindPythonLibs into next for CMake, thanks for
the fixes. I also fixed up ParaView's build system to take account of the
new changes and will be looking at Titan next.

Thanks,

Marcus
--
Marcus D. Hanwell, Ph.D.
R&D Engineer, Kitware Inc.
(518) 881-4937
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100924/660d69d2/attachment.html>


More information about the vtk-developers mailing list