[vtk-developers] Regression of vtkLegendBoxActor

[Aashish Chaudhary]

Hi Dave,

I pushed my updated branch and now all the tests should pass (continuous
looks ok after my second push). Apart from fixing the issue I added a new
test as well (there were none before for that class).

With the new branch I added a feature to have a background (and in future I
might put a support to have a texture for the background) for the legend as
we need it for our current project. I will be keeping an eye on the
dashboards tonight.

Thanks again.

Regards,



On Tue, Oct 19, 2010 at 1:27 PM, Aashish Chaudhary <
aashish.chaudhary at kitware.com> wrote:

> Hi Dave,
>
> On Tue, Oct 19, 2010 at 1:16 PM, David Gobbi <david.gobbi at gmail.com>wrote:
>
>> Hi Aashish,
>>
>> Some of the dashboard tests are failing due to changes to line 796 of
>> Hybrid/vtkLegendBoxActor.cxx:
>>
>>    posX = p1[0] + this->Padding +
>>                 0.25*symbolSize*(p2[0] - p1[0] - 2.0*this->Padding);
>>
>> If the "0.25" is changed back to "0.5", then the tests pass.  I don't
>> know if that is the correct fix, though.
>>
>> I will have a look. All the tests that I ran at the time passed. There
> could be a logical issue here.
>
>
>> There also seems to be an error at line 917:
>>
>>      if( this->Icon[i])
>>        {
>>        renderedSomething +=
>> this->IconActor[i]->RenderOpaqueGeometry(viewport);
>>        }
>>
>> I'm guessing that this should be "if( this->IconImage[i] )" instead of
>> "this->Icon[i]"
>
>  David
>>
>
> That sounds about right. I will fix this too. The idea is you can have
> icons, symbols and or a background plane. In fact I am still working on it
> so its not done (background plane) yet.
>
> Thanks,
>
>
>
> --
> | Aashish Chaudhary
> | R&D Engineer
> | Kitware Inc.
> | www.kitware.com
>



-- 
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20101020/0d78a10f/attachment.html>