[vtk-developers] Code review request: vtkBinaryBlobPerimeter2D

Marcus D. Hanwell marcus.hanwell at kitware.com
Mon Oct 18 16:10:30 EDT 2010


Hi David,

If you fancy being a guinea pig...you can run,

./Utilities/SetupForDevelopment.sh

If you set up an account at http://review.source.kitware.com/, give
the script your username it will attempt to set up a Gerrit remote
too. Then from your topic branch,

git prepush # shows you what you are about to push to Gerrit
git gerrit-push # pushes the current topic branch to Gerrit for review.

You will need to run ./Utilities/Scripts/SetupGitAliases.sh that I
just pushed to get this new alias. The advantage is that any VTK
developer can watch the VTK project, and be notified when new patches
are submitted. We can do line-by-line review of patches, and fetch
your topic branch by copying and pasting a line from the web GUI.

I will be adding more documentation about using this soon, but I think
Gerrit will really help us to integrate patches from the community,
and review new code proposals more easily.

Marcus

On Mon, Oct 18, 2010 at 1:10 PM, Robert Maynard
<robert.maynard at kitware.com> wrote:
> Hi David,
> Would you be interested in pushing this to Gerrit for code review?
>
> On Mon, Oct 18, 2010 at 11:14 AM, David Doria <daviddoria at gmail.com> wrote:
>>
>> This class was motivated by the Matlab function bwperim
>> (http://www.mathworks.com/help/toolbox/images/ref/bwperim.html). It
>> finds all white pixels which have a black neighbor (the perimeters of
>> white blobs in a binary image).
>>
>> The code can be found here:
>> http://github.com/daviddoria/vtkBinaryBlobPerimeter
>>
>> Any comments?
>>
>> David
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>
>
>
> --
> Robert Maynard
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>



More information about the vtk-developers mailing list