[vtk-developers] Multisampling in vtkCocoaRenderWindow

Marcus D. Hanwell marcus.hanwell at kitware.com
Wed Nov 24 22:22:28 EST 2010


On Wed, Nov 24, 2010 at 6:21 PM, David Thompson <dcthomp at sandia.gov> wrote:
>>> I don't see your inline comments. Did you not publish them (are they
>>> still marked "Draft"?) or does Gerrit make comments private (do *you*
>>> see any of *my* inline comments?)
>>
>> They do say draft.  I don't see the word 'publish' anywhere in Gerrit's
>> UI.  If I click my comment I have a textfield and three buttons: Save,
>> Cancel, Discard.  After pressing Save it still shows 'Draft'.  Clearly
>> I'm doing something wrong.
>>
>> Also suspicious is that, although I've logged it, at the top right it
>> shows "Anonymous Coward (65)" where I think maybe my user name should
>> be...
>>
>> I do see your comments.
>
> Sean,
>
> I can't remember whether clicking the "Update" button at the top of the
> patch diff publishes the comments or whether you must also click the "Up to
> change" link followed by the "Review" button in the Patch Set 1 box. But one
> of the two.
>
You need to click review, and click submit in there (optionally
entering a comment such as "see my inline comments"). Until you do
that they will remain draft and only visible to you.

Marcus



More information about the vtk-developers mailing list