[vtk-developers] Best way to contribute to VTK ? - Fwd: [GitHub] nolden sent you a pull request from nolden/VTK

[Moreland, Kenneth]

Is submitting patches to the mailing list now the officially sanctioned method of providing contributions (as opposed to publishing on a public repository such as Marco has done)?  Will this change in the near future when we plan to move to a branchy workflow (which as I understand it now has plans for a more open "staging" repository)?

Perhaps this would be a good topic for the next ARB.

-Ken


On 7/6/10 7:38 AM, "Dave Partyka" <dave.partyka at kitware.com> wrote:

The most visible way is to send a patch to the vtk list. If you use the git patch commands you can create patches that will preserve the author (Marco in this case) as git has separate Author and Committer fields. See this wiki at the bottom on how to create a patch.

http://vtk.org/Wiki/VTK/Git#Submitting_a_patch

On Tue, Jul 6, 2010 at 9:24 AM, Jean-Christophe Fillion-Robin <jchris.fillionr at kitware.com> wrote:
Hi Folks,

Since VTK souce code is available using Git, the repository can be forked very easily and people can contribute quite easily.

Being also available on github, Marco from DKFZ (German research cancer institute) forked it and added a patch. As he mentioned, "Pull request" doesn't seem to "work". What could be the best way for him to share his patch.

Beside of the following page http://www.vtk.org/VTK/project/getinvolved.html ,
Is there any documentation available regarding the "contribution" workflow ?
Is the mailing list the preferred way to share contribution ?
Will the ownership of the original "patcher" be maintained ?

I added Marco in CC, feel free to answer that email and let him know the best way to share his work.

Thks
Jc


---------- Forwarded message ----------
From: GitHub <noreply at github.com>
Date: Wed, Jun 30, 2010 at 9:17 AM
Subject: [GitHub] nolden sent you a pull request from nolden/VTK
To: jchris.fillionr at kitware.com




nolden wants you to pull from nolden/VTK at 9ba9588

Body: Hi,

this is a bugfix for the rendering of utf8 characters. The handling of signed / unsigned was incorrect. As a result only 7bit characters were rendered, though in general the code was ok for 8bit characters.

cc Steven and JC, since I don't know if the "KItware" user reads pull requests.

View repository: http://github.com/nolden/VTK/tree/9ba958806256e38ae4ae4fc424c37f8a7eea2ae9




   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100706/a16b3421/attachment.html>