[vtk-developers] valgrind suppressions

[Dave Partyka]

Okay, suppression removed and VTK is patched. I don't have ITK write access
at the moment though.

On Wed, Jan 20, 2010 at 12:07 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> I agree if it can be fixed it should not be suppressed. David C. I
> think we have the same issue with itk.
>
> Let's remove the suppression and I'll apply David C.'s change to both
> vtk and itk.
>
> Bill
>
> On Wed, Jan 20, 2010 at 11:35 AM, Dave Partyka <dave.partyka at kitware.com>
> wrote:
> > Dude! That ruins my performance! ;-)
> > I agree, I debated making a similar fix a few months ago but decided to
> > leave it.
> >
> > On Wed, Jan 20, 2010 at 11:31 AM, David Cole <david.cole at kitware.com>
> wrote:
> >>
> >> Or.....
> >> .....you could actually fix it as it deserves instead of sweeping it
> under
> >> the rug like the zlib people encourage us to in their faq.
> >>
> >> I fixed it back in November in the CMake code base:
> >>
> >>
> http://public.kitware.com/cgi-bin/viewcvs.cgi/Utilities/cmzlib/deflate.c?root=CMake&r1=1.2&r2=1.3
> >>
> >> Things should be *fixed* not *suppressed* when possible.
> >>
> >>
> >> 2 cents,
> >> David C.
> >>
> >>
> >> On Wed, Jan 20, 2010 at 10:02 AM, Francois Bertel
> >> <francois.bertel at kitware.com> wrote:
> >>>
> >>> The valgrind report of today on arkadia will have this suppression
> rule.
> >>>
> >>> On Wed, Jan 20, 2010 at 8:47 AM, Dave Partyka <
> dave.partyka at kitware.com>
> >>> wrote:
> >>> > Done.
> >>> >
> >>> > On Wed, Jan 20, 2010 at 8:28 AM, Bill Lorensen
> >>> > <bill.lorensen at gmail.com>
> >>> > wrote:
> >>> >>
> >>> >> Could someone add the following valgrind suppression to the
> >>> >> suppressions files used by
> >>> >>
> >>> >> amber2.kitware Linux-Valgrind
> >>> >> and
> >>> >> arkadia.kitware all-debug-g++-valgrind
> >>> >>
> >>> >> {
> >>> >>   Some zlib suppressions. See www.zlib.net/zlib_faq.html#faq36
> >>> >>   Memcheck:Cond
> >>> >>   fun:longest_match
> >>> >>   fun:deflate_slow
> >>> >>   fun:vtk_zlib_deflate
> >>> >> }
> >>> >>
> >>> >> This is responsible for most of the conditional jump errors.
> >>> >>
> >>> >> Thanks,
> >>> >>
> >>> >> Bill
> >>> >> _______________________________________________
> >>> >> Powered by www.kitware.com
> >>> >>
> >>> >> Visit other Kitware open-source projects at
> >>> >> http://www.kitware.com/opensource/opensource.html
> >>> >>
> >>> >> Follow this link to subscribe/unsubscribe:
> >>> >> http://www.vtk.org/mailman/listinfo/vtk-developers
> >>> >>
> >>> >
> >>> >
> >>> > _______________________________________________
> >>> > Powered by www.kitware.com
> >>> >
> >>> > Visit other Kitware open-source projects at
> >>> > http://www.kitware.com/opensource/opensource.html
> >>> >
> >>> > Follow this link to subscribe/unsubscribe:
> >>> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >>> >
> >>> >
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> François Bertel, PhD  | Kitware Inc. Suite 204
> >>> 1 (518) 371 3971 x113 | 28 Corporate Drive
> >>>                      | Clifton Park NY 12065, USA
> >>> _______________________________________________
> >>> Powered by www.kitware.com
> >>>
> >>> Visit other Kitware open-source projects at
> >>> http://www.kitware.com/opensource/opensource.html
> >>>
> >>> Follow this link to subscribe/unsubscribe:
> >>> http://www.vtk.org/mailman/listinfo/vtk-developers
> >>>
> >>
> >>
> >> _______________________________________________
> >> Powered by www.kitware.com
> >>
> >> Visit other Kitware open-source projects at
> >> http://www.kitware.com/opensource/opensource.html
> >>
> >> Follow this link to subscribe/unsubscribe:
> >> http://www.vtk.org/mailman/listinfo/vtk-developers
> >>
> >>
> >
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100120/c66037e0/attachment.html>