[vtk-developers] Move2 rendering tests

[David Doria]

On Tue, Jan 5, 2010 at 9:40 AM, David Doria <daviddoria+vtk at gmail.com> wrote:
> On Mon, Jan 4, 2010 at 1:01 PM, Moreland, Kenneth <kmorel at sandia.gov> wrote:
>> Uh, shouldn’t it be both:
>>
>> IF (VTK_USE_DISPLAY AND VTK_DATA_ROOT)
>>
>> VTK_USE_DISPLAY must be true in order to create OpenGL windows to render the
>> image and VTK_DATA_ROOT must be true in order to have a base image to test
>> against.
>>
>> -Ken
>>
>>
>> On 12/24/09 9:35 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>>
>> Agree
>>
>> On Thu, Dec 24, 2009 at 11:31 AM, David Doria <daviddoria+vtk at gmail.com>
>> wrote:
>>> I believe SurfacePlusEdges.cxx and TestLabelPlacementMapper.cxx should
>>> be moved from
>>>
>>> IF(VTK_USE_DISPLAY)
>>> to
>>> IF(VTK_DATA_ROOT)
>>>
>>> in
>>> VTK/Rendering/Testing/Cxx/CMakeLists.txt
>>>
>>> They both use an image from VTKData. They both pass with the DATA_ROOT
>>> set and fails without.
>>>
>>> Agree/disagree?
>>>
>>> Thanks,
>>>
>>> David
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>>
>>
>>
>>
>>    ****      Kenneth Moreland
>
> Makes sense. I added:
>
>  IF(VTK_USE_DISPLAY AND VTK_DATA_ROOT)
>      SurfacePlusEdges.cxx
>      TestLabelPlacementMapper.cxx
>  ENDIF(VTK_USE_DISPLAY AND VTK_DATA_ROOT)
>
> Look good? Let me know and I'll commit it.
>
> Thanks,
>
> David
>

Clearly, this should have been:

  IF(VTK_USE_DISPLAY AND VTK_DATA_ROOT)
  SET(RenderingTestsWithArguments
      ${RenderingTestsWithArguments}
      SurfacePlusEdges.cxx
      TestLabelPlacementMapper.cxx
      )
  ENDIF(VTK_USE_DISPLAY AND VTK_DATA_ROOT)

I accidentally committed (trying to learn some more cvs), so the
change has been made.

I was trying to see what would be committed when I commit.

I tried
cvs -n commit

but there was not useful output. According to the man page, I thought
it would show me exactly what it was going to do without actually
doing it. I guess not? Anyone know how to say "which files will be
affected when I commit"?

Thanks,

David