[vtk-developers] vtkPlane non-static wrappers

Bill Lorensen bill.lorensen at gmail.com
Tue Feb 2 10:08:37 EST 2010


This doxygen page maps classes to tests.
http://www.vtk.org/doc/nightly/html/pages.html


On Tue, Feb 2, 2010 at 8:37 AM, David Doria <daviddoria+vtk at gmail.com> wrote:
> On Tue, Feb 2, 2010 at 8:19 AM, Will Schroeder <will.schroeder at kitware.com>
> wrote:
>>
>> David-
>>
>> Looking at the code it seems that vtkPlane::IntersectWithLine assumes a
>> unit normal.
>>
>> There are several ways to determine where code is being called/tested
>> from. Grep works, admittedly brute force but effective. Or use a debugger
>> and set a break point at a particular function to see where it is invoked.
>> Fancier methods exist, I'll leave it to the better developers to describe.
>>
>> While I think it's great that you are considering adding tests, remember
>> that every test takes time to run, meaning that the developer's time to make
>> changes, test and check in code increases. Therefore we are optimally
>> looking for a minimal set of tests (and minimal data) to cover the entire
>> code base. Several years ago Ken Martin (and others of the community) went
>> through the exercise of removing extraneous tests and data because it took
>> way too long to run the test suite.
>>
>> Will
>>
>
> I agree that the tests should not be extraneous. However, introducing new
> functions means introducing new tests, right?
> The two possibilities are:
> 1) Find where vtkPlane is currently being tested and add tests for the new
> functions there
> 2) add TestPlane.cxx
> Were you saying that more testing code is time consuming? Or the number of
> actual tests is what is time consuming? I.e. if (2) is chosen, is that
> significantly worse than (1)?
> Thanks,
>
> David
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>



More information about the vtk-developers mailing list