[vtk-developers] KdTree FindPointsWithinRadius

David Cole david.cole at kitware.com
Wed Aug 25 15:05:53 EDT 2010


On Wed, Aug 25, 2010 at 2:26 PM, pat marion <pat.marion at kitware.com> wrote:

> Hi David,
>
> Sorry I didn't get back to you on this.  I don't really want to argue for
> or against this change, but here are some comments...
>
> vtkKdTreePointLocator is a leaf class that implements the
> vtkAbstractPointLocator interface.  It would be best if new interface
> methods were be added at the abstract layer and then implemented in each
> leaf class.
>
> A potential problem with your proposed implementation is that it assumes
> the vtkDataSet is a vtkPointSet, which may not be true.
>
> I definitely agree that the proposed api is convenient, but it doesn't add
> new power to the class.
>
> Pat
>
> On Wed, Aug 25, 2010 at 9:15 AM, David Doria <daviddoria+vtk at gmail.com<daviddoria%2Bvtk at gmail.com>
> > wrote:
>
>>   Because I bet it is a common thing that many users have to deal with
>>> fighting all of the time. It just seems like it should be provided. What
>>> would be the harm in giving access a few ways?
>>>
>>> David
>>>
>>
>> Ok so we have 1 yay and 1 nay - any other comments?
>>
>> I would like to propose that we standardize some kind of voting system for
>> "thumbs up/thumbs down" type of feature additions like this. What always
>> seems to happen without this type of system is someone posts a suggestion, a
>> couple of people make small comments, and then it dies. There is no reason
>> small things like this should take more than a day or two to "accept",
>> "accept with major revisions", or "reject" - but they seem to take months.
>>
>> I have created a vote for the new FindPointsWithinRadius function here:
>> http://www.surveymonkey.com/s/GNFMZ8K
>>
>> The problem may remain that very few people vote (the same as very few
>> people reply on the mailing list). There needs to be a system where if no
>> one votes then the default action is to move forward. I support adding
>> things unless someone is opposed (with a good reason) versus NOT adding
>> things unless lots of people are actively supportive.
>>
>> David
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>>
>>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>

Pat didn't want to argue for or against this change, but his comments speak
for themselves. I think his comments should count as -2 in your voting
scheme, unless you re-implement your patch to account for both comments.

David C.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100825/48e003d4/attachment.html>


More information about the vtk-developers mailing list