[vtk-developers] [PATCH] FIX: Use of uninitialized variable and use better error code

Jeff Baumes jeff.baumes at kitware.com
Fri Dec 4 09:34:56 EST 2009


Looks good, I committed it.

/cvsroot/VTK/VTK/IO/vtkOggTheoraWriter.cxx,v  <--  IO/vtkOggTheoraWriter.cxx
new revision: 1.2; previous revision: 1.1

Jeff

On Fri, Dec 4, 2009 at 4:19 AM,  <themiwi at gmail.com> wrote:
> From: Michael Wild <themiwi at users.sourceforge.net>
>
> Signed-off-by: Michael Wild <themiwi at users.sourceforge.net>
> ---
>  VTK/IO/vtkOggTheoraWriter.cxx |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/VTK/IO/vtkOggTheoraWriter.cxx b/VTK/IO/vtkOggTheoraWriter.cxx
> index b0677f8..8416854 100644
> --- a/VTK/IO/vtkOggTheoraWriter.cxx
> +++ b/VTK/IO/vtkOggTheoraWriter.cxx
> @@ -266,7 +266,7 @@ int vtkOggTheoraWriterInternal::Write(vtkImageData *id)
>   // encode the frame from the last call.
>   // have to do leap-frogging, because otherwise we can't
>   // write the EOS page with the last frame in End().
> -  int ret;
> +  int ret = 1;
>   if (this->haveImageData)
>     {
>     ret = this->EncodeFrame(this->thImage,0);
> @@ -578,7 +578,7 @@ void vtkOggTheoraWriter::Write()
>     {
>     vtkErrorMacro("Error storing image.");
>     this->Error = 1;
> -    this->SetErrorCode(vtkErrorCode::OutOfDiskSpaceError);
> +    this->SetErrorCode(vtkErrorCode::UnknownError);
>     }
>  }
>
> --
> 1.6.5.2
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>



-- 
Jeff Baumes, Ph.D.
R&D Engineer, Kitware Inc.
(518) 881-4932
jeff.baumes at kitware.com



More information about the vtk-developers mailing list