[vtk-developers] [InfoVis] Infovis and rendering kits

[Jeff Baumes]

David,

I was looking at your changes to the kit dependencies, and didn't understand
one of them:
VTK/Infovis/CMakeLists.txt:

-SET(KIT_TCL_LIBS vtkWidgetsTCL)
-SET(KIT_PYTHON_LIBS vtkWidgetsPythonD)
-SET(KIT_JAVA_LIBS vtkWidgetsJava)
-SET(KIT_LIBS vtkWidgets ${VTK_LIBXML2_LIBRARIES} vtkalglib)
+IF(VTK_USE_RENDERING)
+  SET(KIT_TCL_LIBS vtkWidgetsTCL)
+  SET(KIT_PYTHON_LIBS vtkWidgetsPythonD)
+  SET(KIT_JAVA_LIBS vtkWidgetsJava)
+  SET(KIT_LIBS vtkWidgets ${VTK_LIBXML2_LIBRARIES} vtkalglib)
+ELSE(VTK_USE_RENDERING)
+  SET(KIT_TCL_LIBS vtkGraphicsTCL)
+  SET(KIT_PYTHON_LIBS vtkGraphicsPythonD)
+  SET(KIT_JAVA_LIBS vtkGraphicsJava)
+  SET(KIT_LIBS vtkGraphics  ${VTK_LIBXML2_LIBRARIES} vtkalglib)
+ENDIF(VTK_USE_RENDERING)

Nothing in the kit seems to be conditionally compiled based on
rendering/widgets, so why is this conditional there? Views currently only
depends on infovis, but should it really depend on widgets also? Then it
seems we could get rid of this conditional and have infovis only depend on
graphics.

Jeff

On Wed, Mar 18, 2009 at 12:55 PM, Thompson, David C <dcthomp at sandia.gov>wrote:

> Jeff,
>
> Yes, I will start moving these classes around as the wiki page outlines.
>
>   Thanks,
>    David
> ________________________________________
> From: Jeff Baumes [jeff.baumes at kitware.com]
> Sent: Wednesday, March 18, 2009 08:07
> To: Shepherd, Jason F
> Cc: Thompson, David C; Pebay, Philippe P; vtk-developers at vtk.org;
> infovis at public.kitware.com
> Subject: Re: [InfoVis] Infovis and rendering kits
>
> > We should consider removing Infovis/vtkTreeMapViewer.  It is basically
> duplicating functionality found in Views/vtkTreeMapView...
> I agree. The right thing to do is probably to mark all its methods as
> deprecated until the next release, pointing the user to vtkTreeMapView
> in the class comments, then we can remove the class.
>
> >> So... is Kitware OK with me moving these 5 classes from
> >> Infovis to Rendering:
> >>     vtkGraphMapper.cxx
> Depends on filters in Infovis.
>
> >>     vtkInteractorStyleAreaSelectHover.cxx
> Depends on vtkBalloonRepresentation (in Widgets).
>
> >>     vtkInteractorStyleTreeMapHover.cxx
> Depends on vtkBalloonRepresentation (in Widgets) and vtkTreeMapLayout
> (in Infovis).
>
> >>     vtkLabeledTreeMapDataMapper.cxx
> It looks like this could move.
>
> >>     vtkTreeMapViewer.cxx
> Depends on vtkTreeMapLayout (in Infovis).
>
> >> and this class from Infovis to Views:
> >>     vtkViewUpdater.cxx
> Yes, this should definitely happen.
>
> I made a wiki page describing how we could move things in order to
> change dependencies:
>
> http://www.kitware.com/InfovisWiki/index.php/VTK_Kit_Dependencies
>
> Dave, if you want to try to get this working, please feel free.
>
> Jeff
>
>
>


-- 
Jeff Baumes, Ph.D.
R&D Engineer, Kitware Inc.
(518) 881-4932
jeff.baumes at kitware.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20090427/79932703/attachment.html>