[vtk-developers] vtkCleanPolyData

[kent williams]

>From a software-engineering standpoint "I don't think it even broke
any of the tests" is a pretty low standard with which to judge code
changes.

I am more familiar with ITK where the approach to
backwards-compatibility is that it should always be maintained.
Changing the type of data returned from a filter is a pretty drastic
move, even if -- in most cases -- it doesnt break anything obvious.

On Thu, Apr 23, 2009 at 9:43 AM, Andy Bauer <andy.bauer at kitware.com> wrote:
> I did something similar to this for a different filter (I can't remember
> which one) and I don't think it even broke any of the tests.  I can't
> remember if I provided an option of the return precision type or just used
> the input precision type to specify the return precision type.
>
> Andy
>
>>
>> ------------------------------
>>
>> Message: 5
>> Date: Thu, 23 Apr 2009 09:39:08 -0400
>> From: "Rusty Blue" <rusty.blue at kitware.com>
>> Subject: [vtk-developers] vtkCleanPolyData
>> To: <vtk-developers at vtk.org>
>> Message-ID: <49f06f8c.0405be0a.3f25.ffffda2a at mx.google.com>
>> Content-Type: text/plain; charset="us-ascii"
>>
>> Folks,
>>
>>
>>
>> We were using it on a project to remove duplicate points (tolerance == 0),
>> and found out yesterday it wasn't doing what we wanted.  That is, the
>> vtkPoints it creates to replace the input vtkPoints defaults to points of
>> type VTK_FLOAT (our input is double, and we need the extra precision).
>> Seems to be an error to me.
>>
>>
>>
>> The most obvious thing to do would be to have the output vtkPoints be of
>> the
>> same type as the input. but that does mean it will slightly change the
>> behavior of the filter (won't always be VTK_FLOAT points on output).
>> Could
>> instead add a flag that if ON would create output points which are the
>> same
>> type as the input (defaults to OFF).
>>
>>
>>
>> Am I over thinking this one?
>>
>>
>>
>> Rusty
>>
>>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>