[vtk-developers] Changes to VTK Wrapping generated code would quiet useless warnings

[Will Schroeder]

Bill please coordinate with David Cole who is responsible for patching 5.2,
he'll help you out.
W

On Wed, Sep 10, 2008 at 12:30 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> Kent,
>
> I have made changes to Wrapping/vtkWrapTcl.cxx and
> Wrapping/WrapTclInit.cxx that remove these warnings. I don't have a
> vtk HEAD checkout right now. I'm working with the VTK 5.2 version. I
> can't check in my changes to that revision. If you like, I'll send you
> the two files and you can see if they resolve those warnings.
>
> After that, I'll see what it will take to get these into vtk.
>
> Bill
>
>
> On Wed, Sep 10, 2008 at 11:15 AM, kent williams
> <nkwmailinglists at gmail.com> wrote:
> > I am not a VTK developer myself or I might try and track this down and
> > fix it. Anyway:
> >
> > The VTK tcl wrapper uses casts to char * all over the places such that
> > our builds have a ton of warnings like this:
> >
> > .../vtkKWMyRenderWidgetTcl.cxx:71: warning: cast from `const char*' to
> > `char*' discards qualifiers from pointer target type
> >
> > Now I realize this happens because Tcl isn't const-correct, so there
> > are places where you know it's safe to pass Tcl a const char *.
> >
> > But since we're in the world of C++, it would be great  if const_cast
> > was used instead of C-style cast.  This would tell the compiler to
> > STFU in those many cases where the Tcl API is being a stupidhead.
> >
> > Since Dash and CDash both limit the number of warnings they report,
> > having extraneous warnings can push warnings we should care about off
> > of the dashboard, which is a bad thing.
> > _______________________________________________
> > vtk-developers mailing list
> > vtk-developers at vtk.org
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
> _______________________________________________
> vtk-developers mailing list
> vtk-developers at vtk.org
> http://www.vtk.org/mailman/listinfo/vtk-developers
>



-- 
William J. Schroeder, PhD
Kitware, Inc.
28 Corporate Drive
Clifton Park, NY 12065
will.schroeder at kitware.com
http://www.kitware.com
518-371-3971 (phone and fax)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20080910/6fb04e97/attachment.html>