[vtk-developers] pb cvs committing a fix

[David Cole]

That's a very good question. Sounds like maybe there's a bug in the
commit-check script when a brand new file is added, but then it gets caught
when a subsequent commit occurs...?

Jeff, can you replace these dynamic_cast occurrences with SafeDownCast usage
instead? Or is it necessary to rethink this policy and discontinue support
for platforms that do not have dynamic_cast enabled by default...?


Thanks,
David Cole


On 9/5/07, Dean Inglis <dean.inglis at sympatico.ca> wrote:
>
> Hi,
>
> I was trying to head off a red dashboard(s)
> for Borland with vtkConvertSelection.cxx
> by adding a missing include:
> #include <vtksys/stl/iterator>
> but when I went to cvs commit the change
> I get
> ==========================================================
> vtkConvertSelection.cxx uses dynamic_cast.
> dynamic_cast usage is not allowed in VTK.
> Please use SafeDownCast or some other mechanism instead.
> ==========================================================
>
> Not sure how others got these two files
> committed then ???:
> Graphics\vtkConvertSelection.cxx
> IO\vtkSQLiteQuery.cxx
>
>
> Dean
> _______________________________________________
> vtk-developers mailing list
> vtk-developers at vtk.org
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20070905/449f6714/attachment.html>