[vtk-developers] Examples/Build/vtkMy last minute request

[dean.inglis at camris.ca]

small(?) request ...

for those of us who build our own out of source classes
using VTK/Examples/Build/vtkMy as a model,
I am requesting, hopefully before VTK 4.5 is released,
that this example be fully tested under static and shared builds.
It would be great if tcl wrapping worked under static builds
and having doxygen genereated documentation working again 
would be a bonus.

I tried the VTK/Utilities/Upgrading/NewPipeConvert.cmake on
VTK/Examples/Build/vtkMy/Imaging/vtkImageFoo.* and found
that the script does not work correctly:

old vtkImageFoo.cxx:


void vtkImageFoo::ExecuteInformation(vtkImageData *inData, 
                                     vtkImageData *outData)
{
  this->vtkImageToImageFilter::ExecuteInformation(inData, outData);

  if (this->OutputScalarType != -1)
    {
    outData->SetScalarType(this->OutputScalarType);
    }
}


converted vtkImageFoo.cxx:



void vtkImageFoo::ExecuteInformation (
  vtkInformation * vtkNotUsed(request),
  vtkInformationVector **inputVector,
  vtkInformationVector *outputVector)
{
  // get the info objects
  vtkInformation* outInfo = outputVector->GetInformationObject(0);
  vtkInformation *inInfo = inputVector[0]->GetInformationObject(0);

  this->vtkImageToImageFilter::ExecuteInformation (
  vtkInformation * vtkNotUsed(request),
  vtkInformationVector **inputVector,
  vtkInformationVector *outputVector)
{
  // get the info objects
  vtkInformation* outInfo = outputVector->GetInformationObject(0);
  vtkInformation *inInfo = inputVector[0]->GetInformationObject(0);

    outInfo->Set(vtkDataObject::SCALAR_TYPE(),this->OutputScalarType);
    }
}


Even if no-one gets to revamp vtkMy before the release,
shouldn't the conversion script at least work correctly?

Dean