[vtk-developers] ARB-Request: Blessing of vtkPolyData->IsEdge fix

[Rasmus Reinhold Paulsen]

Hi Ken,

Luca has done a new implementation following your suggestions. I would
like to submit it monday. Is that okay with the ARB or do we need a second
round of approval?

Regards,
Rasmus

On Wed, 12 Mar 2003, Ken Martin wrote:

> I think there are a couple problems with the suggested code.
> Specifically three cases come to mind that I think will break it. 
> 
> 1) For a triangle strip with points p0, p1, p2, p3 ... the points p0 and
> p2 do form an edge but would not be correctly reported by the code
> below. 
> 
> 2) for a poly vertex there are no edges but the function could say that
> there was one
> 
> 3) for poly lines if someone checked the first and last point of a poly
> line (in either order) it would match.
> 
> And a minor formatting issue in that the "if" statements do not have {}
> under them. Having said that, the original code was clearly screwed up.
> It looks like a valid solution will have to know what type of cell is
> being considered. Perhaps a switch (this->GetCellType(cell[i])) with the
> current code in the default case but special cases for Tstrips,
> polyvert, and polyline. The whole thing should probably be moved into
> the cxx file as well, getting a bit long and complicated for an inline.