[vtk-developers] bug in vtkMapper (?)

[Charl P. Botha]

On Thu, Mar 13, 2003 at 05:10:02PM -0500, dean.inglis at on.aibn.com wrote:
> void vtkMapper::SetResolveCoincidentTopologyPolygonOffsetParameters(
>                                             float factor, float units)
> {
>   if (factor == vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetFactor &&
>       units == vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetUnits )
>     {
>     return;
>     }
>   vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetFactor = factor;
>   vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetFactor = units;
> }
> 
> Should this not be:
> 
> void vtkMapper::SetResolveCoincidentTopologyPolygonOffsetParameters(
>                                             float factor, float units)
> {
>   if (factor == vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetFactor &&
>       units == vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetUnits )
>     {
>     return;
>     }
>   vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetFactor = factor;
>   vtkMapperGlobalResolveCoincidentTopologyPolygonOffsetUnits = units;
> }

Most definitely.

-- 
charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/