[vtk-developers] Problems with DICOM reader

[Andy Cedilnik]

Hi Matt,

Thank you for your changes.

I am not sure about templated classes in API, I am not aware of any
problem with that. The logic used in other Utilities together with the
logic from VTK should be fairly easy to duplicate in DICOM Parser. 

I am not sure what the right solution is for std namespace. Maybe
somebody else would have some idea.

Thank you.

				Andy

On Wed, 2003-06-11 at 10:25, Turek, Matthew W (Research) wrote:
> > 1. It only works when ansi streams are on.
> 
> Yes. I am willing to change the DICOMParser library to allow ansi/non-ansi
> if it's not too difficult. The DICOMParser is used outside of vtk, though,
> so I'll probably have to copy the vtk logic.
>  
> > 2. DICOMParser library does not follow static / shared flag of the rest
> > of VTK. That means it is always build static.
> 
> Yes. The DICOMParser has templated classes in the API. This is still a
> problem for creating DLLs if I remember correctly. I'm open to suggestions
> here.
> 
> > 3. Indentation of files is wrong.
> 
> I have fixed (I think) the indentation of vtkDICOMImageReader.h
> vtkDICOMImageReader.cxx. 
> 
> > 4. There is a prototype for class myvector in the header file of a vtk
> > class. It should really be vtkDICOMImageReaderVector the way it is used.
> 
> I have fixed this.
> 
> > 5. There are references to std namespace (std::string), which should be
> > vtkstd.
> 
> I have changed this in vtkDICOMImageReader. I'm leaving DICOMParser as is,
> since it's used outside of vtk.