[vtk-developers] Re: Dashboard results

[Will Schroeder]

Hi David-

I agree that what you suggest is better. I'm not sure that I would change 
it myself
due to the potential hassle it might cause. If you feel it is important 
enough, IMHO
I'd say go ahead. If you do, please deprecate the method (with macros and 
#ifndef VTK_REMOVE_LEGACY_CODE) as has been done in the last couple of days.
Also, please track down all uses of the legacied method RotateWXYZ() (in 
.cxx, .tcl,
.py, and Java) and replace them with Rotate().

Will

> > Hi David-
> >
> > Send the vtk/python/install.py to Ken and I.
> >
> > At 10:59 AM 12/7/2000 -0500, David Gobbi wrote:
> >
> > >3) rename 'RotateWXYZ' to 'Rotate' (a la OpenGL), but leave the old
> > >    RotateWXYZ in place of course.
> >
> > I'm having trouble understanding the reason for the rename.  Could you
> > try harder to convince me?
>
>
>Well, here goes.  The main issue I have with 'WXYZ' is that it suggests
>that you are applying a quaternion transformation, which is not really the
>case: the 'w' in a quaternion is not an angle.
>
>
>Also, 'RotateWXYZ' is longer than 'Rotate' and the 'WXYZ' doesn't add
>any significant additional meaning.  When I see 'WXYZ' I don't immediately
>think 'angle + axis,' there is nothing in 'W' that signifies 'angle' and
>'XYZ' usually signifies a point rather than an axis.
>If anything, I think 'quaternion' which, as I said earlier, is not
>the same thing.
>
>
>So,  Rotate(double angle, const double axis[3])
>or   RotateWXYZ(double angle, const double axis[3])
>
>
>my preference is for the former.