[Smtk-developers] SMTK code review, more Remus debugging

[Robert Maynard]

Overall the branch looks good to me. I might have missed it but when a
bridge starts a server how do you capture and advertise what the
endpoint back to that server is?

In smtk/common/Paths.cxx Have you thought about simplifying the OS
includes, maybe to something like:

#ifdef __APPLE__
#  include "smtk/common/PathsHelperMacOSX.h"
#elif defined(__CYGWIN__)
//cygwin also defines _WIN32 so it most come first
#  include "smtk/common/PathsHelperUnix.h"
#elif defined(_WIN32)
#  include "smtk/common/PathsHelperWindows.h"
#else
#  include "smtk/common/PathsHelperUnix.h"
#endif


On Sat, Nov 8, 2014 at 7:22 PM, David Thompson
<david.thompson at kitware.com> wrote:
> Hi Rob,
>
> If you have a minute, could you take a look at smtk/smtk.py on the stage/smtk-remote-python branch? It has some changes that load the bridge Python-libraries when the main smtk module is loaded (inside try:except: clauses so that missing/broken bridges do not disable SMTK).
>
> It also has the advantage of putting the bridge modules at
>
>   smtk.bridge.cgm
>   smtk.bridge.remote
>
> instead of other places like the current bridge modules.
>
> I'm asking you for the review because you were the last one to touch the modules (getting cgmSMTKPython into the smtk::bridge::cgm C++ namespace instead of cgmsmtk::cgm).
>
>         Thanks,
>         David