<div dir="ltr">Thanks. I have fixed the issues which came from the fact we never built it with the double type and it was not working as expected. The patch is <a href="https://github.com/SimonRit/RTK/commit/78d7b39bf30c7567f18055137f18debf0383387a">here</a> and the python packages are available <a href="https://dev.azure.com/simonrit/RTK/_build/results?buildId=504&view=artifacts">here</a>.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 6, 2020 at 10:19 AM Jerome Lesaint <<a href="mailto:lesaint.jerome@gmail.com">lesaint.jerome@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Ok, thanks! <br><div><br></div><div>Just to let you know : I only added a rtkADMMTV[...].wrap file and built. It recompiles ALL the wrappings but ONLY them.</div><div>As you suspected, the guy is a tricky one. It failed to compile with the attached log.</div><div><br></div><div>Should I log anything to put this in the development pipeline ?</div><div>Thanks again for your help,</div><div>Jérome</div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mar. 5 mai 2020 à 21:51, Simon Rit <<a href="mailto:simon.rit@creatis.insa-lyon.fr" target="_blank">simon.rit@creatis.insa-lyon.fr</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">In my experience, it does not recompile everything but it does recompile a significant part but that's very variable depending on how much you change. If you want a better answer, I think you can ask what to expect to ITK guys on <a href="http://discourse.itk.org/" target="_blank">discourse</a>.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 5, 2020 at 3:48 PM Jerome Lesaint <<a href="mailto:lesaint.jerome@gmail.com" target="_blank">lesaint.jerome@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks Simon for the quick response.<div>One question before I give it a try : when re-building after creating the .wrap file, does it only compiles the desired file or does it rebuild the whole ITK again ? Sorry in advance for this probably stupid question, but quite a different game...</div><div>In other words, can I try on one file or should I first check all the missing filters that I need to recompile only once.</div><div><br></div><div>Thanks,</div><div>Jérome</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mar. 5 mai 2020 à 15:28, Simon Rit <<a href="mailto:simon.rit@creatis.insa-lyon.fr" target="_blank">simon.rit@creatis.insa-lyon.fr</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div>Hi Jérôme,</div><div>Not everything is wrapped in Python yet. To know if a filter should be wrapped, you can check if there is a corresponding file in the <a href="https://github.com/SimonRit/RTK/tree/master/wrapping" target="_blank">wrapping</a> subdirectory. You can try to create one rtkADMMTotalVariationConeBeamReconstructionFilter.wrap file by copying <a href="https://github.com/SimonRit/RTK/blob/master/wrapping/rtkADMMWaveletsConeBeamReconstructionFilter.wrap" target="_blank">rtkADMMWaveletsConeBeamReconstructionFilter.wrap</a> and to just change the filter name. This wrapping could be tricky so let us know if does not work directly. It it does, please create a pull request!</div><div>Cheers,</div><div>Simon<br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 5, 2020 at 3:00 PM Jerome Lesaint <<a href="mailto:lesaint.jerome@gmail.com" target="_blank">lesaint.jerome@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Dear all,<div><br></div><div>I have build ITK with the ModuleRTK and ITK_WRAP_PYTHON flags set to ON.</div><div>Everything seems to work fine except that some RTK filters are missing. E.G ADMMTotalVariationConeBeamReconstructionFilter is not available.</div><div><br></div><div>Is it expected behavior ? Or have I missed something in the build process ?</div><div><br></div><div>Far less critical : once the submodule RTK is loaded in python, the first call to any RTK object takes quiet a long time to execute. I also have a few warnings (like the one below) when this first call runs.</div><div><br></div><div>
<p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">Template itk::PyBuffer<itk::Image<itk::CovariantVector<double,2>,2>></span></p>
<p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"><span> </span>already defined as <class 'itkPyBufferPython.itkPyBufferICVD22'></span></p>
<p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"><span> </span>is redefined as <class 'itkPyBufferPython.itkPyBufferICVD22'></span></p><p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures"><br></span></p><p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;line-height:normal;color:rgb(0,0,0)">Thanks in advance for your help,</p><p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;line-height:normal;color:rgb(0,0,0)"><br></p><p style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;line-height:normal;color:rgb(0,0,0)">Jérome</p></div></div>
_______________________________________________<br>
Rtk-users mailing list<br>
<a href="mailto:Rtk-users@public.kitware.com" target="_blank">Rtk-users@public.kitware.com</a><br>
<a href="https://public.kitware.com/mailman/listinfo/rtk-users" rel="noreferrer" target="_blank">https://public.kitware.com/mailman/listinfo/rtk-users</a><br>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>