[Rtk-users] HNC reader

[Simon Rit]

I think I would first check if there is some code to bunzip on ITK's side
(it's not very clear from a quick search in the repo).
If not, then I'll indeed create a cmake option (e.g., RTK_USE_BUNZIP2) and
include the code when activated. You can avoid compiling the cxx files from
cmake but you'll probably need a preprocessor option in rtkConfiguration.h
<https://github.com/SimonRit/RTK/blob/master/rtkConfiguration.h.in> (as
e.g. RTK_USE_CUDA).
Don't hesitate to submit a work in progress as a PR if you need some help.
Thanks!
Simon

On Wed, Nov 20, 2019 at 11:26 AM <gabriele.belotti.bergamo at gmail.com> wrote:

> Thanks Simon!
> I’m able to retrieve those codes for a start and that’s good! Currently
> I’m using 1.4.0 so I don’t have to fiddle around too much.
> How would you go for making the bzip2 dependency optional? Maybe creating
> an option flag in CMake and editing the reader accordingly?
> Gabriele
>
>
>
> *Da:* Simon Rit <simon.rit at creatis.insa-lyon.fr>
> *Inviato:* mercoledì 20 novembre 2019 10.49
> *A:* gabriele.belotti.bergamo at gmail.com
> *Cc:* rtk-users <rtk-users at public.kitware.com>
> *Oggetto:* Re: [Rtk-users] HNC reader
>
>
>
> Hi,
>
> I think there's been a confusion on my side when writing the release notes
> of RTK 1.4. I merged a pull request from Andreas Gravgaard who implemented
> the Xim reader based on the Hnc reader. There is a commit
> <https://github.com/SimonRit/RTK/commit/dc987fca11ae283b07547af19efcd26ad377a4da>
> which includes Hnc but this other commit
> <https://github.com/SimonRit/RTK/commit/9a1754f6e9f7d0257702fc9b48be724c74750990>
> deleted it before merging.
>
> See the related PR <https://github.com/SimonRit/RTK/pull/72> and mailing
> list conversation
> <https://public.kitware.com/pipermail/rtk-users/2016-September/010334.html>
> .
>
> We can probably include the reader in RTK if we can make the bzip2
> dependency optional using Geoff's code.
>
> Sorry for the mess,
>
> Simon
>
>
>
> On Wed, Nov 20, 2019 at 10:11 AM <gabriele.belotti.bergamo at gmail.com>
> wrote:
>
> Dear RTK users,
>
> There is mentions of a .hnc reader in the 1.4.0 release (
> https://www.openrtk.org/RTK/news/201802_release1.4.php) but I can’t find
> it linked in any version I tried (1.4.0 and 2.0.0/1).
> I think this may be a mistake so I wanted to raise the issue.
>
> I hope this is useful for anyone other than me!
>
> Gabriele
>
> _______________________________________________
> Rtk-users mailing list
> Rtk-users at public.kitware.com
> https://public.kitware.com/mailman/listinfo/rtk-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://public.kitware.com/pipermail/rtk-users/attachments/20191120/1fcf09ad/attachment-0001.html>