[Paraview] plugins with 5.2

[Utkarsh Ayachit]

Burlen,

Looking at the code, the problem is not with the plugin (or
add_paraview_plugin), which indeed add the dependency as appropriate,
the issue is in io/CMakeLists.txt [1]. When you use VTK_LIBRARIES,
you're linking against all VTK modules and its dependencies, which is
really an over kill. Instead, change to using COMPONENTS for the
find_package(VTK ..) or find_package(ParaView...) calls e.g. [2].

Utkarsh


[1] https://github.com/LBL-EESA/TECA/blob/master/io/CMakeLists.txt#L34-L42
[2] https://gitlab.kitware.com/sensei/sensei-pub/blob/master/sensei/CMakeLists.txt#L78-86

On Tue, Jan 3, 2017 at 5:38 PM, Burlen Loring <burlen.loring at gmail.com> wrote:
> sure, although I hope this isn't asking too much, as the build has a few
> dependencies, I think for this only NetCDF is needed.
>
> here is the repo
> https://github.com/LBL-EESA/TECA
> plugin is in the ParaView dir.
>
>
> On 01/03/2017 01:35 PM, Utkarsh Ayachit wrote:
>>
>> Burlen,
>>
>> Happy new year to you too!
>>
>> Hmm, that's odd. Can you share the plugin code with me? Let's see if I
>> can reproduce the issue.
>>
>> Utkarsh
>>
>> On Tue, Jan 3, 2017 at 2:13 PM, Burlen Loring <bloring at lbl.gov> wrote:
>>>
>>> Hi Utkarsh, Happy new year!
>>>
>>> I have a couple of questions about the new way.
>>>
>>> Shouldn't this be automatically added by ADD_PARAVIEW_PLUGIN macro like
>>> the
>>> rest of the PV related link dependencies?
>>> Should you really need to link Qt to all plugins?
>>>
>>> My plugin is a number of simple server side only classes, for ex a
>>> reader.
>>> It has no need of Qt. I'd rather not have Qt as a dependency of my
>>> project.
>>>
>>> Burlen
>>>
>>>
>>> On 12/22/2016 12:17 PM, Utkarsh Ayachit wrote:
>>>
>>> Burlen,
>>>
>>> See Qt dependencies changes documented here:
>>>
>>> http://www.paraview.org/ParaView3/Doc/Nightly/www/cxx-doc/MajorAPIChanges.html
>>>
>>> include(ParaViewQt) # generally not needed, since auto-included
>>> pv_find_package_qt(qt_targets
>>>    QT4_COMPONENTS QtGui
>>>    QT5_COMPONENTS Widgets)
>>>
>>> pv_qt_wrap_cpp(moc_files ${headers})
>>> pv_qt_wrap_ui(ui_files ${uis})
>>>
>>> ...
>>> target_link_libraries(${target} LINK_PRIVATE ${qt_targets})
>>>
>>>
>>> Utkarsh
>>>
>>> On Wed, Dec 21, 2016 at 1:25 PM, Burlen Loring <burlen.loring at gmail.com>
>>> wrote:
>>>>
>>>> After upgrading to 5.2 my plugin is not compiling. When I configure the
>>>> plugin I see a few pages of the following:
>>>>
>>>> CMake Warning (dev) at io/CMakeLists.txt:54 (add_library):
>>>>    Policy CMP0028 is not set: Double colon in target name means ALIAS or
>>>>    IMPORTED target.  Run "cmake --help-policy CMP0028" for policy
>>>> details.
>>>>    Use the cmake_policy command to set the policy and suppress this
>>>> warning.
>>>>
>>>>    Target "teca_io" links to target "Qt4::QtCore" but the target was not
>>>>    found.  Perhaps a find_package() call is missing for an IMPORTED
>>>> target,
>>>> or
>>>>    an ALIAS target is missing?
>>>> This warning is for project developers.  Use -Wno-dev to suppress it.
>>>>
>>>> then linker errors
>>>>
>>>> [ 32%] Linking CXX shared library ../lib/libteca_io.so
>>>> /bin/ld: cannot find -lQt4::QtCore
>>>> /bin/ld: cannot find -lQt4::QtGui
>>>> collect2: error: ld returned 1 exit status
>>>> io/CMakeFiles/teca_io.dir/build.make:402: recipe for target
>>>> 'lib/libteca_io.so' failed
>>>> make[2]: *** [lib/libteca_io.so] Error 1
>>>> CMakeFiles/Makefile2:196: recipe for target
>>>> 'io/CMakeFiles/teca_io.dir/all' failed
>>>> make[1]: *** [io/CMakeFiles/teca_io.dir/all] Error 2
>>>> Makefile:127: recipe for target 'all' failed
>>>> make: *** [all] Error 2
>>>>
>>>> It's not a library so I set  the policy to new,  and the cmake configure
>>>> errors out. Any idea what's missing?
>>>>
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Please keep messages on-topic and check the ParaView Wiki at:
>>>> http://paraview.org/Wiki/ParaView
>>>>
>>>> Search the list archives at: http://markmail.org/search/?q=ParaView
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/paraview
>>>>
>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Please keep messages on-topic and check the ParaView Wiki at:
>>> http://paraview.org/Wiki/ParaView
>>>
>>> Search the list archives at: http://markmail.org/search/?q=ParaView
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/paraview
>>>
>>>
>