[Paraview] Bug in redo camera/property link

[Utkarsh Ayachit]

Federico,

Thanks for offering to fix this issue. I think the problem here is that we
don;t have an undo-element that can support undo/redoing link
creations/deletions. A fix to overcome the problem would be to
pqLinksModel::addCameraLink()
to clear the undo-stack at the end of the operation, thus user can no
longer undo/redo the link creation -- thus not cause  a segfault.

To add support for undo/redo, one needs to write a vtkSMUndoElement
subclass that can be pushed on to the undo-stack with enough state
information to know what it needs to do on undo and redo. For starters,
every place a link is created, we can manually create this new undo-element
subclass and initialize it and then push it on the undo stack. Check out
the other subclasses of vtkSMUndoElement, they will make it clear what such
a class needs to do.

Utkarsh



On Fri, Feb 27, 2015 at 3:21 AM, Federico Veronesi <f.veronesi at scsitaly.com>
wrote:

> Dear all,
>
> I found this bug on redo camera link (but it occours anytime I try to redo
> a link)
>
> Add source to renderview
> split layout
> add source to renderview2
> link camera between the two views
> UNDO the link
> REDO the link
> CRASH (on PV 4.2 debug) , view destroyed on PV 4.3.1 (release)
>
> I reported it on Mantis : http://www.paraview.org/Bug/view.php?id=15347
>
> I found out that the problem rises because in vtkSMSessionProxyManager
> when trying to load the state of the link the corresponding classname is
> not stored in the message.
>
> If somebody can point me out where to look I'll be happy to help with the
> fix.
> Regards
>
>
> --------------------------------
> Federico Veronesi, PhD
> SCS s.r.l. - Via Parini 1, Casalecchio di Reno (BO) Italy
> CINECA   - Via Magnanelli 6/3, Casalecchio di Reno (BO) Italy
> Phone:  +39 051 6171624
> E-mail: f.veronesi at scsitaly.com
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ParaView Wiki at:
> http://paraview.org/Wiki/ParaView
>
> Search the list archives at: http://markmail.org/search/?q=ParaView
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/paraview
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/paraview/attachments/20150301/3b46e9b5/attachment.html>