[Paraview] system hdf5 and 3.98rc1

[Utkarsh Ayachit]

I think FindHDF5.cmake needs to be cleaned up. There are occassions
when HDF5_HL_LIBRARY
gets defined  and other occasions when HDF5_hdf5_hl_LIBRARY gets defined.
That's confusing to say the least. I am going to check with the Cmake folks
here and try to figure out what's the right approach.

In the meantime, if simply using HDF5_hdf5_hl_LIBRARY works for you, I can
update the if() block to test for both HDF5_hdf5_hl_LIBRARY or HDF5_HL_LIBRARY.
Does that sound reasonable?

Utkarsh


On Fri, Nov 16, 2012 at 4:29 AM, Francois Bissey <fbissey at slingshot.co.nz>wrote:

> cmake 2.8.9, the wiki says that for 3.98rc1 2.8.8+ is suitable. HDF5_DIR
> is not set that's a system install in standard location (/usr).
> This is what ccmake on paraview 3.98rc1 reports:
>  HDF5_CXX_COMPILER_EXECUTABLE     HDF5_CXX_COMPILER_EXECUTABLE-NOTFOUND
>
>  HDF5_C_COMPILER_EXECUTABLE       /usr/bin/h5pcc
>
>  HDF5_C_INCLUDE_DIR               /usr/include
>
>  HDF5_DIFF_EXECUTABLE             /usr/bin/h5diff
>
>  HDF5_DIR                         HDF5_DIR-NOTFOUND
>
>  HDF5_Fortran_COMPILER_EXECUTAB   /usr/bin/h5pfc
>
>  HDF5_HL_INCLUDE_DIR              /usr/include
>
>  HDF5_IS_PARALLEL                 ON
>
>  HDF5_hdf5_LIBRARY                /usr/lib64/libhdf5.so
>
>  HDF5_hdf5_LIBRARY_DEBUG          HDF5_hdf5_LIBRARY_DEBUG-NOTFOUND
>
>  HDF5_hdf5_LIBRARY_RELEASE        /usr/lib64/libhdf5.so
>
>  HDF5_hdf5_hl_LIBRARY             /usr/lib64/libhdf5_hl.so
>
>  HDF5_hdf5_hl_LIBRARY_DEBUG       HDF5_hdf5_hl_LIBRARY_DEBUG-NOTFOUND
>
>  HDF5_hdf5_hl_LIBRARY_RELEASE     /usr/lib64/libhdf5_hl.so
>
>  HDF5_m_LIBRARY                   /usr/lib64/libm.so
>
>  HDF5_m_LIBRARY_DEBUG             HDF5_m_LIBRARY_DEBUG-NOTFOUND
>
>  HDF5_m_LIBRARY_RELEASE           /usr/lib64/libm.so
>
>  HDF5_rt_LIBRARY                  /usr/lib64/librt.so
>
>  HDF5_rt_LIBRARY_DEBUG            HDF5_rt_LIBRARY_DEBUG-NOTFOUND
>
>  HDF5_rt_LIBRARY_RELEASE          /usr/lib64/librt.so
>
>  HDF5_sz_LIBRARY                  /usr/lib64/libsz.so
>
>  HDF5_sz_LIBRARY_DEBUG            HDF5_sz_LIBRARY_DEBUG-NOTFOUND
>
>  HDF5_sz_LIBRARY_RELEASE          /usr/lib64/libsz.so
>
>  HDF5_z_LIBRARY                   /usr/lib64/libz.so
>
>  HDF5_z_LIBRARY_DEBUG             HDF5_z_LIBRARY_DEBUG-NOTFOUND
>
>  HDF5_z_LIBRARY_RELEASE           /usr/lib64/libz.so
>
>
>
> I understand that it is very curious since there are no such variables
> as HDF5_hdf5_* in FindHDF5.cmake shipped with cmake. A grep on
> paraview's sources suggest that they may originate in the superbuild:
> grep -ri hdf5_hdf5 ../ParaView/*
> ../ParaView/SuperBuild/CMakeLists.txt:
> -DHDF5_hdf5_LIBRARY:FILEPATH=${HDF5_LIBRARY}
> ../ParaView/SuperBuild/CMakeLists.txt:
> -DHDF5_hdf5_LIBRARY_RELEASE:FILEPATH=${HDF5_LIBRARY}
> ../ParaView/SuperBuild/CMakeLists.txt:
> -DHDF5_hdf5_hl_LIBRARY:FILEPATH=${HDF5_HL_LIBRARY}
> ../ParaView/SuperBuild/CMakeLists.txt:
> -DHDF5_hdf5_hl_LIBRARY_RELEASE:FILEPATH=${HDF5_HL_LIBRARY})
>
> And the relevant piece of code in SuperBuild/CMakeLists.txt is here:
> # Build HDF5
> list(APPEND HDF5_dependencies zlib szip)
> list(APPEND ParaView_dependencies HDF5)
> include(External_HDF5)
> set(HDF5_ARGS
>   -DVTK_USE_SYSTEM_HDF5:BOOL=ON
>   -DHDF5_DIR:PATH=${HDF5_install}
>   -DHDF5_FOUND:BOOL=ON
>   -DHDF5_INCLUDE_DIRS:PATH=${HDF5_INCLUDE_DIR}
>   -DHDF5_INCLUDE_DIR:PATH=${HDF5_INCLUDE_DIR}
>   -DHDF5_LIBRARIES:FILEPATH=${HDF5_LIBRARY};${HDF5_HL_LIBRARY}
>   -DHDF5_LIBRARY:FILEPATH=${HDF5_LIBRARY}
>   -DHDF5_HL_LIBRARY:FILEPATH=${HDF5_HL_LIBRARY}
>   -DHDF5_hdf5_LIBRARY:FILEPATH=${HDF5_LIBRARY}
>   -DHDF5_hdf5_LIBRARY_RELEASE:FILEPATH=${HDF5_LIBRARY}
>   -DHDF5_hdf5_hl_LIBRARY:FILEPATH=${HDF5_HL_LIBRARY}
>   -DHDF5_hdf5_hl_LIBRARY_RELEASE:FILEPATH=${HDF5_HL_LIBRARY})
>
> Any opinions?
>
> Francois
>
> On 16/11/12 09:40, Utkarsh Ayachit wrote:
> > What cmake version are you using and what is your HDF5_DIR variable set
> > to, if at all?
> >
> > Utkarsh
> >
> >
> > On Mon, Nov 12, 2012 at 9:45 PM, <fbissey at slingshot.co.nz
> > <mailto:fbissey at slingshot.co.nz>> wrote:
> >
> >     Another problem I have now is with system hdf5. I get the following:
> >     Disabling NETCDF4 support since HDF5_HL is missing.
> >
> >     Yet I have hdf5_hl installed and it is detected by cmake as well
> since
> >     HDF%_hdf5_hl_LIBRARY is defined and pointing to the right thing.
> >     I believe that the cmake testing logic in
> >     VTK/ThirdParty/netcdf/vtknetcdf/CMakeLists.txt
> >     is wrong:
> >     set (USE_NETCDF4 OFF)
> >     if (NOT VTK_USE_SYSTEM_HDF5)
> >       # using VTK's HDF5, we always build that with HL support.
> >       set (USE_NETCDF4 ON)
> >     elseif(HDF5_HL_LIBRARY)
> >       set (USE_NETCDF4 ON)
> >     else()
> >       message(STATUS "Disabling NETCDF4 support since HDF5_HL is
> missing.")
> >     endif ()
> >
> >     HDF5_HL_LIBRARY is the wrong variable to test, it should be
> >     HDF5_hdf5_hl_LIBRARY.
> >     The change works for me. By the way any chance to be able to use the
> >     system
> >     netcdf  as debian does in its build (and that I shamelessly copied
> >     in Gentoo).
> >
> >     Francois
> >
> >     _______________________________________________
> >     Powered by www.kitware.com <http://www.kitware.com>
> >
> >     Visit other Kitware open-source projects at
> >     http://www.kitware.com/opensource/opensource.html
> >
> >     Please keep messages on-topic and check the ParaView Wiki at:
> >     http://paraview.org/Wiki/ParaView
> >
> >     Follow this link to subscribe/unsubscribe:
> >     http://www.paraview.org/mailman/listinfo/paraview
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.paraview.org/pipermail/paraview/attachments/20121116/1514fc53/attachment.htm>