[Paraview] IceT problem

[Moreland, Kenneth]

OK.  I just pushed the changes to the ParaView master branch.

-Ken

   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

From: "Biddiscombe, John A." <biddisco at cscs.ch<mailto:biddisco at cscs.ch>>
Date: Thu, 16 Jun 2011 21:44:31 +0000
To: Kenneth Moreland <kmorel at sandia.gov<mailto:kmorel at sandia.gov>>, "paraview at paraview.org<mailto:paraview at paraview.org>" <paraview at paraview.org<mailto:paraview at paraview.org>>
Subject: RE: [Paraview] IceT problem

Thanks Ken, seems fine now

JB

From: Moreland, Kenneth [mailto:kmorel at sandia.gov]
Sent: 16 June 2011 21:01
To: Biddiscombe, John A.; paraview at paraview.org<mailto:paraview at paraview.org>
Subject: Re: [Paraview] IceT problem

John,

Earlier this week I merged a change in ParaView that uses the latest (not yet released) version of IceT.  You have the dubious honor of reporting the first problem.

It appears that the MSVC debugger is checking to make sure variables are set before used as an argument to a function. (Cool feature.  I didn't know it did that.)  It looks like I violated that.  I am pretty sure this is benign; the state that leads to uninitialized variables should mean they won't be used in the function.  It's still bad and dangerous practice though, so thanks for pointing it out.

Attached is a patch that should fix the problem.  Please apply it to reduce.c and let me know if it resolves the problem.

-Ken

   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

From: "Biddiscombe, John A." <biddisco at cscs.ch<mailto:biddisco at cscs.ch>>
Date: Thu, 16 Jun 2011 18:39:51 +0000
To: "paraview at paraview.org<mailto:paraview at paraview.org>" <paraview at paraview.org<mailto:paraview at paraview.org>>
Subject: [Paraview] IceT problem

When running in parallel on windows, I get this (frequently)

I just closed the debugger and forgot to copy the stack trace, but can post it if it helps.

Is it a known issue? (I’m using IceT master, head of current git from the paraview repo) – can I just set piece offset to the process rank?

Line 109 of reduce.c
    if (icetIsEnabled(ICET_COLLECT_IMAGES)) {
        result_image = reduceCollect(composited_image,
                                     compose_tile,
                                     piece_offset);



JB

[cid:image001.png at 01CC2C7F.568A3A70]

--
John Biddiscombe,                            email:biddisco @ cscs.ch
http://www.cscs.ch/
CSCS, Swiss National Supercomputing Centre  | Tel:  +41 (91) 610.82.07
Via Cantonale, 6928 Manno, Switzerland      | Fax:  +41 (91) 610.82.82

_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.paraview.org/pipermail/paraview/attachments/20110620/145691b7/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 30907 bytes
Desc: image001.png
URL: <http://www.paraview.org/pipermail/paraview/attachments/20110620/145691b7/attachment-0001.png>