[Paraview] Problem with custom time-aware reader

[Moreland, Kenneth]

Karl,

Your patch seems overly complicated.  There is exactly one check in vtkFileSeriesReader to determine whether the internal reader has time, and that is in RequestInformation.  It is a lot less intrusive to just add a condition to that check there.  I've attached a patch that implements the no-time flag in this way.  (BTW, I changed the name from IgnoreTimeStepValues to IgnoreReaderTime since a reader can in fact specify time without specifying time steps.)

-Ken


On 9/18/09 4:47 AM, "Karl König" <kkoenig11 at web.de> wrote:

Hi,

I dug deeper into the class FileSeriesReader and found out that despite
what I thought and posted earlier everything is already there to be able
to implement a toggle to use/ignore time step values contained in a file
series. I'd like to propose the attached patch. It can be tested with
the attached minimal time series reader plugin, sample input files are
contained. The plugin's server manager XML has been extended to expose
the IgnoreTimeStepValues checkbox provided by the patched class
FileSeriesReader.

I don't see the patch interfering with existing readers relying on class
FileSeriesReader.
Any thoughts?

Thanks in advance for feedback,
Karl



   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.paraview.org/pipermail/paraview/attachments/20090918/c4455393/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vtkFileSeriesReader.patch
Type: application/octet-stream
Size: 3485 bytes
Desc: vtkFileSeriesReader.patch
URL: <http://www.paraview.org/pipermail/paraview/attachments/20090918/c4455393/attachment.obj>