[Paraview] problem with latest CVS

[Utkarsh Ayachit]

Thanks Paul and Jerome,

All those files helped. The issue was exposed where there were
multiple call to ADD_PARAVIEW_PLUGIN in  a CMakeLists.txt file. The
problem was since ADD_PARAVIEW_PLUGIN was a macro, the state of some
variables was cleared cleanly and hence leaked from one call to
another. Fixed that by converting the ADD_PARAVIEW_PLUGIN to a
function (instead of a macro) so variable scopes work as expected.

I've committed a fix. Let me know if that doesn't help.

Utkarsh

On Thu, Dec 3, 2009 at 11:32 AM, Jérôme <jerome.velut at gmail.com> wrote:
> Hi,
> Thanks for all! Unfortunately, I am currently re-compiling ParaView from
> scratch... I will give you a feed-back as soon as my tiny comp' has
> finished.
>
> What I can say is that your fix about 'static' link is ok. I did not have to
> wait the compilation to end, maybe because this is CMake-script related?
>
> The build error is now reported on a DICOM reader and I am having the
> following message :
>
> /home/dje/Softwares/VesselExtraction/Plugins/ParaView/CoronaryExtractionToolbar_Plugin.cxx:43:93:
> erreur:
> /home/dje/Softwares/VesselExtraction/Plugins/ParaView/vtkSMXML_DICOMImageReader.h
> : Aucun fichier ou dossier de ce type
> /home/dje/Softwares/VesselExtraction/Plugins/ParaView/CoronaryExtractionToolbar_Plugin.cxx:
> In member function ‘virtual void
> CoronaryExtractionToolbar_Plugin::GetXMLs(std::vector<std::basic_string<char,
> std::char_traits<char>, std::allocator<char> >,
> std::allocator<std::basic_string<char, std::char_traits<char>,
> std::allocator<char> > > >&)’:
> /home/dje/Softwares/VesselExtraction/Plugins/ParaView/CoronaryExtractionToolbar_Plugin.cxx:71:
> erreur: ‘DICOMImageReaderDICOMReaderGetInterfaces’ was not declared in this
> scope
> make[2]: ***
> [Plugins/ParaView/CMakeFiles/CoronaryExtractionToolbar.dir/CoronaryExtractionToolbar_Plugin.cxx.o]
> Erreur 1
> make[2]: *** Attente des tâches non terminées....
>
> (Sorry for the frenchy message!!)
> The vtkSMXML_DICOMImageReader.h cannot be found. But he exists ! Attached
> are vtkSMXML_DICOM.....h and the DICOM_plugin cxx and h.
>
> Thanks again,
>
> Jerome
>
>
>
> 2009/12/3 Utkarsh Ayachit <utkarsh.ayachit at kitware.com>
>>
>> Jerome,
>>
>> I tried to mimic your plugin by a small example but could not
>> reproduce your issue. If you don't mind helping me track this down,
>> can you try the following:
>>
>> * First, try clean building -- delete the build directory for the
>> plugin (not paraview) and try again.
>> * Does the vtkSMXML_*.h the compiler is complaining about exist?
>> * What does ICSImageReader_Plugin.cxx look like?
>>
>> Thanks,
>>
>> Utkarsh
>>
>> On Thu, Dec 3, 2009 at 5:20 AM, Jérôme <jerome.velut at gmail.com> wrote:
>> > Utkarsh,
>> >
>> > I have similar problem: the generated vtkSMXML_ header files cannot be
>> > found. Attached is my CMakeLists defining the plugins. Some variables
>> > are
>> > declared in other places. If you need them, tell me.
>> >
>> > Jerome
>> >
>> >
>> > 2009/12/2 Utkarsh Ayachit <utkarsh.ayachit at kitware.com>
>> >>
>> >> Paul,
>> >>
>> >> I've been changing the way plugins are configured. Can you try
>> >> clean-building your plugin? If that doesn't work, can you post your
>> >> CMakeLists.txt file?
>> >>
>> >> Thanks
>> >> Utkarsh
>> >>
>> >> On Wed, Dec 2, 2009 at 6:33 AM, Paul Edwards <paul.m.edwards at gmail.com>
>> >> wrote:
>> >> > I'm getting build errors on my plugins:
>> >> >
>> >> > .....
>> >> > /path/to/build/dir/MyReader/MyReaderGUIPlugin_Plugin.cxx:43:86:
>> >> > error:
>> >> > /path/to/build/dir/MyReader/vtkSMXML_MyReaderSMPlugin.h: No such file
>> >> > or directory
>> >> > /path/to/build/dir/MyReader/MyReaderGUIPlugin_Plugin.cxx: In member
>> >> > function ‘virtual void
>> >> > MyReaderGUIPlugin_Plugin::GetXMLs(std::vector<std::basic_string<char,
>> >> > std::char_traits<char>, std::allocator<char> >,
>> >> > std::allocator<std::basic_string<char, std::char_traits<char>,
>> >> > std::allocator<char> > > >&)’:
>> >> > /path/to/build/dir/MyReader/MyReaderGUIPlugin_Plugin.cxx:69: error:
>> >> > ‘MyReaderSMPluginvtkMyReaderGetInterfaces’ was not declared in this
>> >> > scope
>> >> > make[2]: ***
>> >> >
>> >> > [MyReader/CMakeFiles/MyReaderGUIPlugin.dir/MyReaderGUIPlugin_Plugin.cxx.o]
>> >> > Error 1
>> >> >
>> >> > Is it just me?!
>> >> >
>> >> > Thanks,
>> >> > Paul
>> >> > _______________________________________________
>> >> > Powered by www.kitware.com
>> >> >
>> >> > Visit other Kitware open-source projects at
>> >> > http://www.kitware.com/opensource/opensource.html
>> >> >
>> >> > Please keep messages on-topic and check the ParaView Wiki at:
>> >> > http://paraview.org/Wiki/ParaView
>> >> >
>> >> > Follow this link to subscribe/unsubscribe:
>> >> > http://www.paraview.org/mailman/listinfo/paraview
>> >> >
>> >> _______________________________________________
>> >> Powered by www.kitware.com
>> >>
>> >> Visit other Kitware open-source projects at
>> >> http://www.kitware.com/opensource/opensource.html
>> >>
>> >> Please keep messages on-topic and check the ParaView Wiki at:
>> >> http://paraview.org/Wiki/ParaView
>> >>
>> >> Follow this link to subscribe/unsubscribe:
>> >> http://www.paraview.org/mailman/listinfo/paraview
>> >
>> >
>
>