[Paraview] Crash Reading pvs Using Volume Vis

[Kent Eschenberg]

Submitted as bug 3988. Content below.

Kent
Pittsburgh Supercomputing Center

======

ParaView 2.4.4 on Linux (FC5, i386) crashes when it reads a session-state file (pvs) when the file was made while doing volume visualization.

The crash occurs in vtkPVVolumeAppearanceEditor.cxx as it prepares the vol vis parameters for one of the inputs that is only geometry, i.e., it has no scalar data.

Two changes seemed to fix the problem. In ::SetPVSourceAndArrayInfo replace
+++
  vtkPVDataInformation* dataInfo = source->GetDataInformation();
  if ( !this->PVSource || !this->ArrayInfo || !pvApp || !dataInfo ||
---
with
+++
  if ( !this->PVSource ) return;
  vtkPVDataInformation* dataInfo = source->GetDataInformation();
  if ( !this->ArrayInfo || !pvApp || !dataInfo ||
---
and in ::SetScalarOpacityUnitDistance change
+++
if ( !this->PVSource && this->ArrayInfo
---
to
+++
if ( !this->PVSource || !this->ArrayInfo )
---
Also, several annoying messages saying that "PVSource not set!" were eliminated. Maybe there is a better way to fix the problem.