[Paraview-developers] Moving around ui files in ParaView

[Cory Quammen]

Mathieu's merge request has been merged into VTK master, so one should
not run into this particular problem any more.

Thanks, Mathieu!

Cory

On Tue, Aug 2, 2016 at 5:06 AM, Mathieu Westphal
<mathieu.westphal at kitware.com> wrote:
> Joachim proposition indeed fix the problem.
>
> I've created a Merge Request with this fix, it does not seem to cause any
> problems during paraview or any vtk based applpication compilation, feel
> free to review it.
> https://gitlab.kitware.com/vtk/vtk/merge_requests/1763
>
> Mathieu Westphal
>
> On Mon, Aug 1, 2016 at 5:46 PM, Joachim Pouderoux
> <joachim.pouderoux at kitware.com> wrote:
>>
>> I would propose (not tested yet) to change vtkModuleMacros.cmake:191
>>
>>     include_directories(${${vtk-module}_INCLUDE_DIRS})
>>
>> by
>>
>>     include_directories(BEFORE ${${vtk-module}_INCLUDE_DIRS})
>>
>> What do you think?
>>
>>
>> Joachim Pouderoux, PhD
>>
>> Technical Expert - Scientific Computing Team
>> Kitware SAS
>>
>>
>> 2016-08-01 17:44 GMT+02:00 Joachim Pouderoux
>> <joachim.pouderoux at kitware.com>:
>>>
>>> The workaround would be to add those source and bin directory using the
>>> BEFORE option of the cmake function include_directories().
>>> However, not sure yet where it should be done and there might be a better
>>> fix.
>>>
>>> Joachim Pouderoux, PhD
>>>
>>> Technical Expert - Scientific Computing Team
>>> Kitware SAS
>>>
>>>
>>> 2016-08-01 17:27 GMT+02:00 Mathieu Westphal
>>> <mathieu.westphal at kitware.com>:
>>>>
>>>> Hello
>>>>
>>>> I've moved an .ui file and associated class from Components to
>>>> ApplicationComponents and modified it a bit in a branch.
>>>>
>>>> Compiling my branch from an empty directory works perfectly, but
>>>> compiling it from up to date build directory would fail like this :
>>>>
>>>> error: 'class pqSpreadSheetViewDecorator::pqInternal' has no member
>>>> named 'ExportVisibleColumns'
>>>>
>>>> As if the ui file had not been updated. We have already tracked the
>>>> problem to the fact the build/Qt/Components still contains the old ui_*.h
>>>> file.
>>>>
>>>> Removing it manually fix the problem. but it shows that there may be a
>>>> problem with the include order,
>>>> Is there any reason for the include directory of the current source and
>>>> build directory for not being included before all other include directories
>>>> ?
>>>> Is there a work around for this issue ?
>>>> Because in it's current state, if my branch get merged, anyone compiling
>>>> master from an existing build directory will encounter the ame bug.
>>>>
>>>> Mathieu Westphal
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Search the list archives at:
>>>> http://markmail.org/search/?q=Paraview-developers
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/paraview-developers
>>>>
>>>
>>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at:
> http://markmail.org/search/?q=Paraview-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/paraview-developers
>



-- 
Cory Quammen
R&D Engineer
Kitware, Inc.