[Paraview-developers] plugin filter icon/menu

[Utkarsh Ayachit]

Felipe,

Just detected the duplicate VCR controls issue...a fix is on its way.

Utkarsh

On Fri, Jan 9, 2015 at 10:51 AM, Utkarsh Ayachit
<utkarsh.ayachit at kitware.com> wrote:
> Yup...fixed merged that change as well. Thanks!
> BTW, I don't see the duplicate VCR controls in my build.
>
> Utkarsh
>
> On Fri, Jan 9, 2015 at 5:08 AM, Felipe Bordeu
> <felipe.bordeu at ec-nantes.fr> wrote:
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> thanks I add the line (this->Internal->addProxy(group, name,
>> showInMenu->GetAttribute("icon"));) in my paraview sources and the icons are
>> visible again. thanks.
>>
>> But what about the toolbar?. the "show_in_toolbar" option is also lost.
>>
>> adding these lines(after the line 806 in your patch) make the
>> show_in_toolbar work again.
>>
>>           int show_in_toolbar = 0;
>>           hint->GetScalarAttribute("show_in_toolbar", &show_in_toolbar);
>>           category.ShowInToolbar = category.ShowInToolbar ||
>> (show_in_toolbar == 1);
>>
>> in this case we have to put a new tag in the xml hints.
>>
>>        <ShowInMenu category="PXDMF"
>> icon=":/PXDMFIcons/AnnotateFieldData.png" show_in_toolbar="1" />
>>
>>
>> I don't know if this happens only in my 4.3-RC1 but the View->Toolbars menu
>> show  2 "VCR Controls" submenus. Can anyone confirm this.
>>
>> thanks
>> Felipe
>>
>>
>>
>>
>> Le 08/01/2015 15:48, Utkarsh Ayachit a écrit :
>>> Here's the change:
>>>Â Â Â  http://review.source.kitware.com/#/c/18740/
>>>
>>> Should make it into the official release of 4.3.
>>>
>>> Utkarsh
>>>
>>> On Thu, Jan 8, 2015 at 9:31 AM, Utkarsh Ayachit
>>> <utkarsh.ayachit at kitware.com> wrote:
>>>> Good catch. I don't exactly know what the PipelineIcon hint is.
>>>> Looking at the code I don't think it was intended to be functional.
>>>> I'll track down the developer and figure that part out. I am adding
>>>> support to add a new attribute "icon" to the <ShowInMenu > element.
>>>>
>>>> e.g.
>>>>Â Â Â  <Hints>
>>>>Â Â Â Â Â Â  <ShowInMenu icon="...." />
>>>>Â Â  </Hints>
>>>>
>>>> Utkarsh
>>>>
>>>> On Thu, Jan 8, 2015 at 7:52 AM, Felipe Bordeu
>>>> <felipe.bordeu at ec-nantes.fr> wrote:
>>>>>
>>> Hello,
>>>
>>> I'm porting my plugin into version 4.3 and I'm unable to set the icons
>>> for my filters.
>>> I tried : (http://www.paraview.org/Wiki/ParaView/Plugin_HowTo(
>>>
>>> ...
>>> Â  <Hints>
>>> Â Â Â  <ShowInMenu category="PXDMF" />
>>> Â Â Â  <PipelineIcon name=":/PXDMFIcons/AnnotateFieldData.png"Â  />
>>> Â  </Hints>
>>> </SourceProxy>
>>>
>>> ...
>>> but does not work. Searching for the keyword "PipelineIcon" in the
>>> Paraview sources gives no results.
>>>
>>> also :  the  ShowInMenu shows the filter in a new submenu but the is no
>>> new toolbar as in the 4.2.
>>>
>>> in the 4.2 version this was my GUI xml
>>>
>>> <ParaViewFilters>
>>> Â  <Category name="PXDMF" menu_label="&PXDMF" show_in_toolbar="1">
>>> Â Â Â Â Â  <!-- adds a new category and then adds our filter to it -->
>>> Â Â Â Â Â  <Filter name="AnnotateFieldData"
>>> icon=":/PXDMFIcons/AnnotateFieldData.png" />
>>> Â  </Category>
>>> </ParaViewFilters>
>>>
>>> any ideas.
>>>
>>> Thanks to all. And thanks for this new version.
>>> Felipe
>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Paraview-developers mailing list
>>>>> Paraview-developers at paraview.org
>>>>> http://public.kitware.com/mailman/listinfo/paraview-developers
>>
>> - --
>> Felipe Bordeu Weldt
>> Ingénieur de Recherche
>> - -------------------------------------
>> Tél. : 33 (0)2 40 37 16 57
>> Fax. : 33 (0)2 40 74 74 06
>> Felipe.Bordeu at ec-nantes.fr
>> Institut GeM - UMR CNRS 6183
>> École Centrale Nantes
>> 1 Rue de La Noë, 44321 Nantes, FRANCE
>> - -------------------------------------
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1
>>
>> iQEcBAEBAgAGBQJUr6iHAAoJEE/fMfNgU9/D/VUIAJKWqm+fIhqGckxda4bqrxZI
>> 2ztfvVU8h9PbJN1LFpf8pSHTMETI4Lf6LN8YDuUH6F5YI/jEZHl7wF1N1ygaDHI4
>> 6hllc1/lyJPd3n3LROoPNd9/A2eUv9oNZzW1u7LjHbKdq/M1yi1XKYUzFKJdgAlb
>> 4W060OBKlalGcgasHxWa7+U5breML/3D11Why+HP/oTAA4p9HdRIyUxjpBjmYxRk
>> luS4bnEi9RlD1vDFzldYQm2fzNHJ4jllq35QbYcTzkOHSTNtRzwAqXGHc1J0z0V7
>> Wi9bUu1uKKfYC0pxHYrjYh1/PlJ5+cVoFW9+cPIOUwB0/Ex95Tr2TzyiO62ZLPI=
>> =ta6C
>> -----END PGP SIGNATURE-----
>>
>>
>> _______________________________________________
>> Paraview-developers mailing list
>> Paraview-developers at paraview.org
>> http://public.kitware.com/mailman/listinfo/paraview-developers
>>