[Paraview-developers] [Paraview] ParaView GateKeeper Review Summary

[Sebastien Jourdain]

Hi Ken,

We assume that a developer that would have a branch in next or stage would
follow the gatekeeper review emails. And if his branch didn't get merged,
he has the opportunity to reply to the gatekeeper review e-mail.

But basically the reason why a branch will be kicked out of next would be
because the branch was not ready to be merged into master.
1) Meaning the gatekeeper is not aware that the branch should be merged
into master as no bug gatekeeper-review entry was created.
2) The branch has change the day the gatekeeper review happen. (In that
case such behavior may be unfair and we might merge automatically any
branch marked as gatekeeper-review automatically - but not promising
anything yet)
3) Maybe it was a dead branch used to exercise the dashboard on a given
topic but not meant to go to master.

Moreover, if a branch was not ready, it means that it needs more changes
which will imply a least a new push/merge. And after such push/merge it
will be easier to track any regression instead of summing up all the
regression that each branch may bring and then just ignoring them assuming
they are not related to your changes.

On top of that, we offer the developer to rewrite its history after each
gatekeeper review if a given topic was not merged to master.

If that seems too complex or too annoying for the community we can
certainly do what we used to do.

Thanks,

Seb



On Wed, Nov 28, 2012 at 11:02 AM, Moreland, Kenneth <kmorel at sandia.gov>wrote:

>   Is there a formal feedback mechanism to let developers know their topic
> has been kicked out of next and the reason for it?  For example, a note in
> the bug tracker that pushes the status back to todo or an email to the
> developer if the reason is because there is no open issue for the change?
>
>  -Ken
>
>    From: Sebastien Jourdain <sebastien.jourdain at kitware.com>
> Date: Wednesday, November 28, 2012 8:01 AM
> To: "paraview at paraview.org" <paraview at paraview.org>, "
> paraview-developers at paraview.org" <paraview-developers at paraview.org>
> Subject: [EXTERNAL] [Paraview] ParaView GateKeeper Review Summary
>
>   Caution, from now on, topics that were in next before the gatekeeper
> review and that haven't been merged to master will be automatically
> removed from next so next will basically be equivalent to master.
>
>  The reason is to give any contributor the opportunity to rebase their
> work on top of master in order to get a cleaner history or even remove
> their branch.
> Therefore, from now on, branch that are on stage should be manually
> pushed by their owner to next after gatekeeper review. The following
> command can be run to do so:
>
>  # To push without rebasing your work (don't need to be in git repo)
> # -------
> $ ssh git at paraview.org stage ParaView merge YOUR_STAGE_BRANCH_NAME
>
>
>  # To rebase your work on top of master
> # -------
> $ git fetch origin
> $ git checkout -b YOUR_STAGE_BRANCH_NAME stage/YOUR_STAGE_BRANCH_NAME
> $ git rebase origin/master
> $ git push stage :YOUR_STAGE_BRANCH_NAME
> $ git stage-push
> $ git stage-merge
>
>
>  Topics remaining on stage: (NOT in NEXT)
> ---------------------------------------------
>   12742_scalar_bar_improvements
>   13024-debug-leaks-view
>   13047_java_wrapping_for_paraviewcore_and_eclipse_swt_rendering
>   13374-slac-multiple-modes
>   streaming-temporal-AMR
>   13598-VRGrabWorldFix
>   AddTransformsToRepresentations
>   topic_commandproperty_314
>   amr_streaming_pass2
>   update_manta_test
>   array-calculator-field-data-support
>   use_more_precise_value_to_describe_interactive_render_timeout
>   co-processing-fortran-utilities
>   vr_improvements
>   fix-use-directory-name-hint
>
>
>  Topics merged into master:
> ---------------------------------------------
>         0013683_fix_vtkForceTime
> (VTK)   13225_make_vtkPVDataInformation_more_robust
>         13229_fix_connect_button_enabled_status
>         13439_fix_interactive_render_delay
>         13494-multi-apply
>         13671_spreadsheet_cell_connectivity
>         13673_cleanup_pointsprite_plugin
>         13674_fix_static_qt_plugins
> (VTK)   13681-matplotlib-python-interp
>         13684_enh_csv_reader
>         cgns-patch
>         fix-coprocessing-tests
>         fix-gmv-test
>         integrate_gmv_reader_contribution
>         minor_fix
>         update_nightly_testing_to_RC3
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/paraview-developers/attachments/20121128/daaff2a3/attachment-0001.htm>