[Paraview-developers] git log and files changed

Kyle Lutz kyle.lutz at kitware.com
Wed Aug 1 17:54:18 EDT 2012


On Wed, Aug 1, 2012 at 2:46 PM, Scott, W Alan <wascott at sandia.gov> wrote:
> I am trying to see what was changed with a git tag.  The tag is
> b9daec33b23f04efa7bf81911bb830f03cefe360.  Specifically, I am trying to see
> the source files and lines that  were changed.  How is this done?
>
> Thanks,
>
> Alan
>
>
>
>
> _______________________________________________
> Paraview-developers mailing list
> Paraview-developers at paraview.org
> http://public.kitware.com/mailman/listinfo/paraview-developers
>

"git show b9daec33b23f04efa7bf81911bb830f03cefe360" yields:

commit b9daec33b23f04efa7bf81911bb830f03cefe360
Author: Utkarsh Ayachit <utkarsh.ayachit at kitware.com>
Date:   Wed May 16 15:41:27 2012 -0400

    BUG #13179. Fixed pattern matching issue causing files to be hidden.

    Files in a file-group sometimes were hidden away due to incorrect filtering.
    Updated the filter to handle filtering of names in a file group by
testing the
    group's name rather than the name of the file itself.

diff --git a/Qt/Core/pqFileDialogFilter.cxx b/Qt/Core/pqFileDialogFilter.cxx
index ff2bb4f..b5b4306 100644
--- a/Qt/Core/pqFileDialogFilter.cxx
+++ b/Qt/Core/pqFileDialogFilter.cxx
@@ -144,12 +144,23 @@ bool pqFileDialogFilter::filterAcceptsRow(int
row_source, const QModelIndex& sou

   if(this->Model->isDir(idx))
     {
+    QString str = this->sourceModel()->data(idx).toString();
     return true;
     }

-  QString str = this->sourceModel()->data(idx).toString();
-  bool pass = this->Wildcards.exactMatch(str);
-  return pass;
+  if (source_parent.isValid())
+    {
+    // if source_parent is valid, then the item is an element in a file-group.
+    // For file-groups, we use pass any file in a group, if the group's label
+    // passes the test (BUG #13179).
+    QString str = this->sourceModel()->data(source_parent).toString();
+    return this->Wildcards.exactMatch(str);
+    }
+  else
+    {
+    QString str = this->sourceModel()->data(idx).toString();
+    return this->Wildcards.exactMatch(str);
+    }
 }

Is that what you were looking for?

-kyle


More information about the Paraview-developers mailing list