[Paraview-developers] PARAVIEW_USE_LOOKMARKS OFF ==> build fails
Berk Geveci
berk.geveci at gmail.com
Thu Jun 30 07:41:47 EDT 2005
I vote for #1 too.
On 6/29/05, Brad King <brad.king at kitware.com> wrote:
> Hi Eric,
>
> The following code appears in vtkPVSource.h:
>
> #ifdef PARAVIEW_USE_LOOKMARKS
> void SetLookmark(vtkPVLookmark *lookmark);
> vtkGetObjectMacro(Lookmark,vtkPVLookmark);
> #endif
>
> The Tcl wrapping code does not pay attention to PARAVIEW_USE_LOOKMARKS
> so it tries to wrap these methods even when this setting is off. That
> results in a compilation failure because the methods do not exist for
> the compiler.
>
> If these methods do not need to be called from Tcl then the simplest
> solution is to just use
>
> #ifdef PARAVIEW_USE_LOOKMARKS
> //BTX
> void SetLookmark(vtkPVLookmark *lookmark);
> vtkGetObjectMacro(Lookmark,vtkPVLookmark);
> //ETX
> #endif
>
> to avoid the problem. Otherwise there are a few options:
>
> 1.) Remove the ability to disable lookmarks and always build them.
> 2.) Provide these methods even when not using lookmarks but leave them
> empty.
> 3.) Remove the need to call these methods from Tcl and then BTX/ETX them.
>
> From a software testing point of view I prefer #1. Just the fact that
> this problem was not showing up on the dashboard is an example of why
> configurable build options make testing hard.
>
> What do you think?
>
> Thanks,
> -Brad
> _______________________________________________
> Paraview-developers mailing list
> Paraview-developers at paraview.org
> http://public.kitware.com/mailman/listinfo/paraview-developers
>
More information about the Paraview-developers
mailing list