[Paraview-developers] Segfault deleting filters when volume rendering

[Shead, Timothy]

Since I'm the new guy, thought I'd run the following past the group
prior to committing.  This issue happens intermittently when volume
rendering is in effect and you delete a filter - it seems that sometimes
the display gets updated *during* the deletion process - in which case
DisplayGUI->VolumeRenderMode is still true, and DisplayGUI->PVSource is
NULL, causing the subsequent dereference and segfault.  Any thoughts?

Many thanks,
Tim Shead


Index: GUI/Client/vtkPVDisplayGUI.cxx
===================================================================
RCS file: /cvsroot/ParaView/ParaView/GUI/Client/vtkPVDisplayGUI.cxx,v
retrieving revision 1.48
diff -u -r1.48 vtkPVDisplayGUI.cxx
--- GUI/Client/vtkPVDisplayGUI.cxx      9 Aug 2005 15:53:53 -0000
1.48
+++ GUI/Client/vtkPVDisplayGUI.cxx      26 Aug 2005 15:54:32 -0000
@@ -114,7 +114,7 @@
     { 
       if (   !this->DisplayGUI
           || !this->DisplayGUI->VolumeRenderMode
-          || !this->DisplayGUI->PVSource->GetDisplayProxy() )
+          || !(this->DisplayGUI->PVSource &&
this->DisplayGUI->PVSource->GetDisplayProxy()))
         {
         return;
         }


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://public.kitware.com/mailman/private/paraview-developers/attachments/20050826/0d9586d0/attachment.html