[Opengeoscience-developers] Request for approval: bug_49_globe_rendering

[Aashish Chaudhary]

Thanks Ben.

On Wed, May 8, 2013 at 12:32 PM, Ben Burnett <benjam.arlyn at gmail.com> wrote:

> Hi Aashish,
>
> I reviewed this branch. I tested basic functionality, but I'm not sure how
> to test the things you actually worked on/added, or if there is a way yet.
>

You can run drawSphere test. That's the new test added to show
the functionality

>
> The code looks decent, a few typos and style issues but nothing major.
>

Can you push fixes for these typos and style issues? I will appreciate
that.



>
> Ben
>
>
> On Tue, May 7, 2013 at 3:26 PM, Aashish Chaudhary <
> aashish.chaudhary at kitware.com> wrote:
>
>> This branch added support for globe rendering for climatepipes. It does
>> not actually provide means to draw the globe yet but added new
>> transformations and a test to support globe rendering for the next branch
>> which I am working on now.
>>
>> It would be nice if someone can approve this branch.
>>
>> Thanks
>>
>>
>> --
>> | Aashish Chaudhary
>> | R&D Engineer
>> | Kitware Inc.
>> | www.kitware.com
>>
>> _______________________________________________
>> Opengeoscience-developers mailing list
>> Opengeoscience-developers at public.kitware.com
>>
>> http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers
>>
>>
>


-- 
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/opengeoscience-developers/attachments/20130508/d4c9590a/attachment.html>