[Opengeoscience-developers] Review

[Ben Burnett]

Done.


On Mon, Jul 22, 2013 at 3:08 PM, Ben Burnett <benjam.arlyn at gmail.com> wrote:

> No we can take it out, I'll do that right now.
>
> -Ben
>
>
> On Mon, Jul 22, 2013 at 2:54 PM, Aashish Chaudhary <
> aashish.chaudhary at kitware.com> wrote:
>
>> Ben,
>>
>> There is lot of code form old-workflow. I am thinking that it may be
>> better if you take it out from this branch before it goes to master.
>>
>> Do you any strong objections to this? Let me know so that I can merge
>> this in master asap.
>>
>> Thanks
>>
>>
>>
>> On Mon, Jul 22, 2013 at 2:47 PM, Aashish Chaudhary <
>> aashish.chaudhary at kitware.com> wrote:
>>
>>> Just to be clear, Chris gave the earlier feedback -:)
>>>
>>> On Fri, Jul 12, 2013 at 5:49 PM, Ben Burnett <benjam.arlyn at gmail.com>wrote:
>>>
>>>> @Aashish: Yes this is just the front end, but there are some backend
>>>> WIP code on this branch as well from the past.
>>>>
>>>> - It seems there are some streaming changes as well, such as
>>>>> streamwork.py and archive.js has some websocket stuff added? Should this
>>>>> stuff be added on this branch?
>>>>>
>>>> I think it came from merging in another branch a while ago, possibly to
>>>> bring in fixes, but I can't remember exactly. I started adding websocket
>>>> stuff to archive to try and get the streaming demo working there, but none
>>>> of it's actually being used, so it should be harmless.
>>>>
>>>>
>>>>> - What is the license of utils/xml2json.py and
>>>>> web/apps/oldworkflow/hint-textbox.js? Need to be careful about adding non
>>>>> BSD stuff.
>>>>>
>>>> It has a custom license
>>>> https://github.com/hay/xml2json/blob/master/LICENSE, with the primary
>>>> piece being "The above copyright notice and this permission notice
>>>> shall be included in all copies or substantial portions of the Software."
>>>> Will this cause problems?
>>>>
>>>
>>> I don;t think so. Its actually a MIT license (xml2json is released
>>> under the terms of the MIT license <http://opensource.org/licenses/MIT>
>>> .)
>>>
>>>>
>>>>
>>>
>>>
>>>>  - Do we need the old workflow code?
>>>>>
>>>> No we shouldn't need it anymore.
>>>>
>>>
>>> Ok, I will merge the code and then you can remove it later. Would that
>>> be Ok?
>>>
>>> - Aashish
>>>
>>>
>>>>
>>>> _______________________________________________
>>>> Opengeoscience-developers mailing list
>>>> Opengeoscience-developers at public.kitware.com
>>>>
>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers
>>>>
>>>>
>>>
>>>
>>> --
>>> | Aashish Chaudhary
>>> | R&D Engineer
>>> | Kitware Inc.
>>> | www.kitware.com
>>>
>>
>>
>>
>> --
>> | Aashish Chaudhary
>> | R&D Engineer
>> | Kitware Inc.
>> | www.kitware.com
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/opengeoscience-developers/attachments/20130722/d026a2a4/attachment.html>