[Opengeoscience-developers] js-lint branch

[Keval Sheth]

Hello Aashish,

All below errors are now fixed. I have made new branch 'geo-jslint-fixes'. Could you please check it and let me know whether the files have passed the test or not?

Regards,
Keval
________________________________
From: Keval Sheth
Sent: Thursday, April 25, 2013 3:01 PM
To: Aashish Chaudhary
Cc: opengeoscience-developers
Subject: RE: [Opengeoscience-developers] js-lint branch

Hello Aashish,

I have made changes in Geo library files( 'fix-jslint-errors' branch), you can check it if the files in Geo directory is passed or not. Also in 'map.js' and 'layer.js' files i am getting below errors:

Strict violation.

    currentElement = this;

Unexpected 'this'.

  this.activeLayer = function() {

Could you please assist us why are we getting this error. When i searched for it i found that we need to add /*jslint validthis: true */, but it didn't resolved the error. Could you please assist us with the above two errors?

Regards,
Keval

________________________________
From: opengeoscience-developers-bounces at public.kitware.com [opengeoscience-developers-bounces at public.kitware.com] on behalf of Keval Sheth [krs435 at students.poly.edu]
Sent: Thursday, April 25, 2013 4:57 AM
To: Aashish Chaudhary
Cc: opengeoscience-developers
Subject: Re: [Opengeoscience-developers] js-lint branch

Hello Aashish,

Thanks a lot. Ya sure, we will handle the geo library once and will be pushing it so that we can find out whether it has been passed it or not.

Regards,
Keval
________________________________
From: Aashish Chaudhary [aashish.chaudhary at kitware.com]
Sent: Thursday, April 25, 2013 4:53 AM
To: Keval Sheth
Cc: opengeoscience-developers
Subject: Re: [Opengeoscience-developers] js-lint branch

Hi Keval,

before that, I tried the branch and found that it broke the code. Actually I am thinking that if you and Manas can handle the geo library first (since hopefully no one is touching that code at this moment). And lets have those files passed. If we run into some issues with those files then we can look into it further. I think if we go module by module or files by files, it will make it easy for us to get it done.

Does it make sense?

Thanks,
Aashish



On Thu, Apr 25, 2013 at 12:25 AM, Keval Sheth <krs435 at students.poly.edu<mailto:krs435 at students.poly.edu>> wrote:
Hello Aashish,

There are few files in which there were no errors while we reviewed using Jslint tool, but still it didn't passed the test and showed as 'failed' in dashboard. Could you please let us know what are the requirements that specific file should pass the test on dashboard apart from removing the errors through Jslint tool.
Below are few files among them from 'geo' folder:
'command.js', 'feature.js', 'latlng.js'

Regards,
Keval
________________________________
From: opengeoscience-developers-bounces at public.kitware.com<mailto:opengeoscience-developers-bounces at public.kitware.com> [opengeoscience-developers-bounces at public.kitware.com<mailto:opengeoscience-developers-bounces at public.kitware.com>] on behalf of Aashish Chaudhary [aashish.chaudhary at kitware.com<mailto:aashish.chaudhary at kitware.com>]
Sent: Thursday, April 25, 2013 3:47 AM
To: opengeoscience-developers
Subject: [Opengeoscience-developers] js-lint branch

Manas, Keval,

What's the current status? Should I go ahead and review it?

- Aashish


--
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com<http://www.kitware.com>



--
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com<http://www.kitware.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/opengeoscience-developers/attachments/20130425/75a7f2d6/attachment.html>