[ITK-users] [ITK] ShapeLabelMap Roundness/Perimeter Calculation Issue

[Johnson, Hans J]

Ebasafa

Can you please modify one of the tests in “ITK/Modules/Filtering/LabelMap/test” to expose the bug that you are encountering?

If you can extend one of these tests so that the test demonstrates the failure (i.e. starts reporting failures to the dashboard), you will gain support of many of the community in fixing the problem in the most robust way.

Thanks,
Hans


-- 


On 5/14/16, 6:18 AM, "Insight-users on behalf of Bradley Lowekamp" <insight-users-bounces at itk.org on behalf of blowekamp at mail.nih.gov> wrote:

>Hello,
>
>Great work tracking the issue down!
>
>Does updating to the 4.10rc1 fix your problem?
>
>Brad
>> On May 13, 2016, at 5:28 PM, ebasafa <ehsan.basafa at gmail.com> wrote:
>> 
>> Thank you for the pointer! After fiddling with the hxx file for a couple
>> hours, I traced the issue further and found out the method vnl_math_abs()
>> called on line 537 (which seems like in the repository has been replaced by
>> itk::Math::abs() but not implemented in the stable release), provides
>> different answers for absolute values in debug and release. Surprisingly,
>> for example, this method reports -1 as absolute value of -1 in release!
>> Replacing that with std::abs() resolves the issue and now roundness and
>> perimeter are the same and (seemingly) correct. I think a bug fix, if not
>> already done via itk::Math as I mentioned, is in order.
>> 
>> 
>> 
>> 
>> --
>> View this message in context: http://itk-insight-users.2283740.n2.nabble.com/ShapeLabelMap-Roundness-Perimeter-Calculation-Issue-tp7588837p7588841.html
>> Sent from the ITK Insight Users mailing list archive at Nabble.com.
>> _____________________________________
>> Powered by www.kitware.com
>> 
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>> 
>> Kitware offers ITK Training Courses, for more information visit:
>> http://www.kitware.com/products/protraining.php
>> 
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>> 
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/insight-users
>> _______________________________________________
>> Community mailing list
>> Community at itk.org
>> http://public.kitware.com/mailman/listinfo/community
>_____________________________________
>Powered by www.kitware.com
>
>Visit other Kitware open-source projects at
>http://www.kitware.com/opensource/opensource.html
>
>Kitware offers ITK Training Courses, for more information visit:
>http://www.kitware.com/products/protraining.php
>
>Please keep messages on-topic and check the ITK FAQ at:
>http://www.itk.org/Wiki/ITK_FAQ
>
>Follow this link to subscribe/unsubscribe:
>http://public.kitware.com/mailman/listinfo/insight-users