[ITK-users] Pulling VNL function into ITK?

[Johnson, Hans J]

Matt,

I have been doing sub-tree merges in private branches, identifying custimizations for VXL in the ITK environmnet, and then making changes in the VXL tree so that there is no need for customizations.

I am hoping to make another pass this weekend and then, hopefully, quit working on VXL for a while.

Alexander Leinoff has been working through clang static analysis and valgrind analysis trying to clean up compiler warnings and errors.

I am mostly concerned about library linking, library installation, and library naming through the ITK install directory right now.  It seems that the ITK version of VXL had many customizations to get VXL installed so that external projects could link against them.

This issue is one that really scares me:  https://github.com/vxl/vxl/issues/127
I’m not quite sure how to attack modernizing this in such a way that it is compatible with ITK ask well.

Hans
-- 








On 2/17/16, 9:39 AM, "Matt McCormick" <matt.mccormick at kitware.com> wrote:

>Hi Davis,
>
>Hans lead some amazing work at updating VNL recently in preparation of
>a major update for ITK recently. This will enable maintenance and
>evolution of VNL in ITK.
>
>@Hans, is it a good time to pull the trigger and do the initial subtree merge?
>
>Thanks,
>Matt
>
>On Wed, Feb 17, 2016 at 7:37 AM, DVigneault <davis.vigneault at gmail.com> wrote:
>> All--
>>
>> There is a function called "double angle_minuspi_to_pi(double angle);" in
>> Insight's vxl branch [1], which hasn't yet made it into the ITK source tree
>> [2].  It looks like this is the commit where the function was added [3].
>> Would it be possible to pull this into ITK?
>>
>> Best, and thanks,
>>
>> --Davis
>>
>> [1]
>> https://github.com/InsightSoftwareConsortium/vxl/blob/master/core/vnl/vnl_math.h
>> [2]
>> https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_math.h
>> [3]
>> https://github.com/InsightSoftwareConsortium/vxl/commit/47460747604cb4058b53d831c3e73da6fa0d7835
>>
>>
>>
>> --
>> View this message in context: http://itk-insight-users.2283740.n2.nabble.com/Pulling-VNL-function-into-ITK-tp7588506.html
>> Sent from the ITK Insight Users mailing list archive at Nabble.com.
>> _____________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://www.kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/insight-users