[Insight-users] bug in itkLabelGeometryImageFilter

[Chr. Rossmanith]

Hi,

I've attached a patch file because I have some trouble using gerrit. 
I've set up gerrit to use a http password but get

error: The requested URL returned error: 403 while accessing 
http://crossmanith@review.source.kitware.com/p/ITK/info/refs

fatal: HTTP request failed

when trying

"git push gerrit HEAD:refs/for/release/itkLabelGeometryImageFilter"

I've created the branch with "git checkout -b 
itkLabelGeometryImageFilter origin/release"

Christina


Am 25.09.2013 14:28, schrieb Bradley Lowekamp:
> Hello,
>
> It's not clear to me quite what you are saying. Perhaps code snippets 
> would have made it clearer, if you are going to refer to variables in 
> you own code.
>
> Are you saying that the ITK filter has a bug? That when it's 
> re-executed some internal variables are not correctly reset?
>
> If you have a fix, you can commit the fix to git and push the fix up 
> to gerrit for review to be merged into the ITK repo.
>
> Here is some information on how to do that:
> http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html
>
> Thanks,
> Brad
>
> On Sep 25, 2013, at 8:23 AM, "Chr. Rossmanith" 
> <cr at neuro.ma.uni-heidelberg.de <mailto:cr at neuro.ma.uni-heidelberg.de>> 
> wrote:
>
>> Hi,
>>
>> to enable using itkLabelGeometryImageFilter in a loop m_AllLabels and 
>> m_LabelGeometryMapper have to be initialized prior to the loop "while 
>> ( !labelIt.IsAtEnd() ) { ... }"   (line 210 in 
>> itkLabelGeometryImageFilter.hxx):
>>
>> m_AllLabels.clear()
>> m_LabelGeometryMapper.clear();
>>
>> How would this fix find its way into ITK?
>>
>> Christina Roßmanith
>>
>> _____________________________________
>> Powered bywww.kitware.com <http://www.kitware.com>
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://www.kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-users
>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-users/attachments/20130925/b7cd5ccd/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-BUG-enable-itkLabelGeometryImageFilter-to-be-used-in.patch
Type: text/x-patch
Size: 1086 bytes
Desc: not available
URL: <http://www.itk.org/pipermail/insight-users/attachments/20130925/b7cd5ccd/attachment.bin>