[Insight-users] Valgrind defects after recent checkins

[Cyrille Faucheux]

That's my fault, sorry for introducing such bug.

Cyrille

----- Mail original -----
De: "Matt McCormick" <matt.mccormick at kitware.com>
À: "Bill Lorensen" <bill.lorensen at gmail.com>
Cc: "Insight-Users" <insight-users at itk.org>
Envoyé: Lundi 26 Août 2013 18:04:17
Objet: Re: [Insight-users] Valgrind defects after recent checkins

Hi Bill,

Thanks for the note.

Yes, you are correct in the location of paddedStreamRead.  I verified with

   ITK/Utilities/Maintenance/runValgrind.sh -R BMPImage

Here is the patch:

  http://review.source.kitware.com/#/c/12445/

Thanks,
Matt

On Mon, Aug 26, 2013 at 12:08 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Folks,
>
> The new BMP code has memory issues as pointed out here:
> http://open.cdash.org/viewDynamicAnalysisFile.php?id=2981829
>
> Looks like the allocation at line 290 in itkBMPImageIO.cxx should be moved
> below the computation of paddedStreamRead.
>
> All defects seem to be the result of the same bug.
>
> Thanks,
>
> Bill
>
>
> _____________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://www.kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-users
>
_____________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://www.kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-users