[Insight-users] [Insight-developers] fixing a few remaining failing tests relating to pixel-centered coordinates

[Luis Ibanez]

Wes,

                Yes, it does fit.

We will insert the warning message, and we can refine the
exact wording once we reach a concensus.


    Luis


----------------
Wes Turner wrote:
> I think a warning makes sense until we have better validation.  
> 
> Michel/Luis is this something that fits in with what you are doing?
> 
> - Wes
> 
> On Thu, May 21, 2009 at 8:37 AM, Bill Lorensen <bill.lorensen at gmail.com 
> <mailto:bill.lorensen at gmail.com>> wrote:
> 
>     Simon,
> 
>     My point is that we have not validated the new code as far as I can
>     tell.
> 
>     Bill
> 
>     On Thu, May 21, 2009 at 7:57 AM, Simon Warfield
>     <simon.warfield at childrens.harvard.edu
>     <mailto:simon.warfield at childrens.harvard.edu>> wrote:
>      > Bill Lorensen wrote:
>      >>
>      >> Yes, I think that will be OK. We should add an Attention: warning to
>      >> the CMakeLists.txt file. Something like:
>      >>
>      >>  SET(msg "Attention: You have chosen to enable the use of
>      >> cell-centered coordinates.")
>      >>
>      >
>      > The tool kit currently uses a mixture of both, so the above is a bit
>      > misleading. How about instead:
>      > SET(msg "Attention: You have chosen to enable the consistent use
>     of centered
>      > pixel coordinates.")
>      >
>      > We should explain the pros and cons of the choice e.g.:
>      >>
>      >>  SET(msg "${msg} This new functionality has not been fully
>     validated.
>      >> USE AT YOUR OWN RISK.")
>      >>
>      >
>      > SET(msg "${msg} The old functionality creates an inconsistent
>     physical
>      > coordinate system.")
>      >>
>      >>  SET(msg "${msg} With this ON, you can expect to see differences in
>      >> registration and interpolation results.")
>      >>
>      >
>      > differences -> improvements
>      >>
>      >> # display the message during the setup
>      >> MESSAGE("${msg}")
>      >>
>      >
>      > --
>      > Simon
>      >>