[Insight-users] MultiScaleHessianBasedMeasureImageFilter

[Luca Antiga]

Dear Adarsh,
  you are right. This was a bug both in the code and the test that  
didn't test for it.
I just committed checks for the cases where number of steps is 0 and 1
(now the filter does nothing in the first case and only runs the  
minimum scale in
the second). I also modified the test to test against these situations.
Thanks for reporting the problem

Luca


On Jun 19, 2009, at 7:49 AM, ramasa at rpi.edu wrote:

>
> Hello everyone,
>
> I was working with the MultiScaleHessianBasedMeasureImageFilter ,  
> that is
> part of the Code/Review. I am using ITK 3.12.0. I think there is a  
> small
> error in the way the code runs through the sigma values in the
> MultiScaleHessianBasedMeasureImageFilter.txx file. If a user enters  
> the
> number of steps to be 1, then the loop would go on forever because  
> of the
> following code section in the function ComputeSigmaValue( int ) in the
> same (.txx) file:
>
> if (m_NumberOfSigmaSteps < 2)
>    {
>    return m_SigmaMinimum;
>    }
>
> The while loop (looping through sigma) checks that sigma be less  
> than or
> equal to m_SigmaMaximum. This will always be true if the user entered
> SigmaMaximum >= SigmaMinimum, and numberOfSigmaSteps = 1.
>
> Thanks,
> Adarsh K. Ramasubramonian,
> Rensselaer Polytechnic Institute
> Troy NY
>
>
> _____________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-users

--
Luca Antiga, PhD
Head, Medical Imaging Unit,
Biomedical Engineering Department,
Mario Negri Institute.
mail: Villa Camozzi, 24020, Ranica (BG), Italy
phone: +39 035 4535-381
email: antiga at marionegri.it
web: http://villacamozzi.marionegri.it/~luca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-users/attachments/20090619/47aede57/attachment-0001.htm>