[Insight-users] Compilation error with inPlace filters

[Miller, James V (Research)]

I put in patch last night.  This issue should be resolved.  Please let me
know if you still have a problem.

Jim

-----Original Message-----
From: Miller, James V (Research) 
Sent: Monday, February 09, 2004 5:08 PM
To: 'Luis Ibanez'; Radhika Sivaramakrishna
Cc: ITK; Miller, James V (Research)
Subject: RE: [Insight-users] Compilation error with inPlace filters


I see what the problem here is.  I'll try to fix it tonight or tomorrow
morning. 

Jim

-----Original Message-----
From: Luis Ibanez [mailto:luis.ibanez at kitware.com]
Sent: Monday, February 09, 2004 2:59 PM
To: Radhika Sivaramakrishna
Cc: ITK; Miller, James V (Research)
Subject: Re: [Insight-users] Compilation error with inPlace filters



Hi Radhika,

This seems to be a bug in the RelabelImageFilter.
The issue has been entered in the bug tracker with ID # 582

http://www.itk.org/Bug/bug.php?op=show&bugid=582&pos=0

In the meantime, please instantiate the RelabelImageFilter
using the same image type for input and output.

----

Unrelated to the error above,... but still worrisome:

In your code you are taking the output of a reader and
using an iterator for changing the value of this image.
(the "mask" image in lines 193 - 201 ).

Then you pass the image as input to another filter.
This is a violation of the pipeline encapsulation.
You should use a threshold image filter instead of
using an iterator through the image. The output of the
filters should be const...  but we still have this
weakness in ITK filters....

The cumulators that you have for frequencies are
being declared unsigned long. They should be floats
or doubles.  Note that Frequencies are not just counters,
they actually provide floating point values.


  Regards,


     Luis


---------------------------------------
Radhika Sivaramakrishna wrote:

> Hi Luis,
> I actually did the checkout this morning and I did see the Dashboard 
> was pretty green. I don't know if I am making a silly mistake or a 
> more serious error.
>
> I have copied my code here which doesn't compile and gives the error 
> indicated below. I think the problem has something to do with the 
> IntImageType I put in for dealing with the Relabel.. filter.
>
> Sorry about not putting the correct subject. Will try to make sure to 
> do it from now on.
>
> Radhika
>
>
> -----Original Message-----
> From: Luis Ibanez [mailto:luis.ibanez at kitware.com]
> Sent: Monday, February 09, 2004 10:34 AM
> To: Radhika Sivaramakrishna
> Cc: ITK
> Subject: Re: [Insight-users] Compilation error with inPlace filters
>
>
> Hi Radhika,
>
>
> A number of changes were made last week for extending
> the functionality of "InPlace" filters.
>
> You probably updated your checkout in the middle of
> one of such modifications.  Please trying cvs updating
> to this morning (since the nightly Dashboard was quite
> green today).
>
>
>   Regards,
>
>
>      Luis,
>
>
> PS. Please don't reuse email threads with other subjects when
>       you post questions about new topics/problems. This is
>      confusing for anybody trying to follow a thread.
>
>
> ---------------------------------------
> Radhika Sivaramakrishna wrote:
>
> > Hi Luis,
> > I am getting this very strange error message while compiling. Can you
> > explain what this could be?
> >
> > /home/rsivaram/Insight/Code/Common/itkInPlaceImageFilter.txx: In member
> >    function `void itk::InPlaceImageFilter<TInputImage,
> >    TOutputImage>::AllocateOutputs() [with TInputImage = main(int,
> >    char**)::IntImageType, TOutputImage = main(int, 
> char**)::ImageType]':
> > /home/rsivaram/Insight/Code/Common/itkImageRegion.h:173:  
> > instantiated from here
> > /home/rsivaram/Insight/Code/Common/itkInPlaceImageFilter.txx:76: no
> > matching
> >    function for call to `itk::InPlaceImageFilter<main(int,
> >    char**)::IntImageType, main(int,
> > char**)::ImageType>::GraftOutput(main(int,
> >    char**)::IntImageType*)'
> > /home/rsivaram/Insight/Code/Common/itkImageSource.txx:95: candidates
> > are: void
> >    itk::ImageSource<TOutputImage>::GraftOutput(TOutputImage*) [with
> >    TOutputImage = main(int, char**)::ImageType]
> >
> >
> > Thanks
> > Radhika
> >
> >
> >
>
>
>                                                     
> ----------------------------------------------------- 
> Confidentiality Notice.
> This email message is for the sole use of the intended recipient(s) 
> and may contain confidential and privileged information. Any 
> unauthorized review, use, disclosure or distribution is prohibited. If 
> you are not the intended recipient, please contact the sender by reply 
> email and destroy all copies of the original message. If you are the 
> intended recipient, please be advised that the content of this message 
> is subject to access, review and disclosure by the sender's Email 
> System Administrator.
>
>  
>
>  
>